All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Hatle <mark.hatle@windriver.com>
To: <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 6/6] sanity.bbclass: Check for mmap_min_addr can	be safely removed
Date: Tue, 1 Mar 2011 19:47:13 -0600	[thread overview]
Message-ID: <4D6DA1A1.3030409@windriver.com> (raw)
In-Reply-To: <1299029911-3973-7-git-send-email-raj.khem@gmail.com>

If we set the value to 65536 in the other patch, I'd prefer this check remain
and check for 65536 instead.  (Or change the check to show that it has a high
probability of working.)

--Mark

On 3/1/11 7:38 PM, Khem Raj wrote:
> * QEMU is already patch to take care of it
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta/classes/sanity.bbclass |   11 -----------
>  1 files changed, 0 insertions(+), 11 deletions(-)
> 
> diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
> index 13940f8..2af6f4b 100644
> --- a/meta/classes/sanity.bbclass
> +++ b/meta/classes/sanity.bbclass
> @@ -166,17 +166,6 @@ def check_sanity(e):
>      if "." in data.getVar('PATH', e.data, True).split(":"):
>          messages = messages + "PATH contains '.' which will break the build, please remove this"
>  
> -    if data.getVar('TARGET_ARCH', e.data, True) == "arm":
> -        # This path is no longer user-readable in modern (very recent) Linux
> -        try:
> -            if os.path.exists("/proc/sys/vm/mmap_min_addr"):
> -                f = file("/proc/sys/vm/mmap_min_addr", "r")
> -                if (f.read().strip() != "0"):
> -                        messages = messages + "/proc/sys/vm/mmap_min_addr is not 0. This will cause problems with qemu so please fix the value (as root).\n\nTo fix this in later reboots, set vm.mmap_min_addr = 0 in /etc/sysctl.conf.\n"
> -                f.close()
> -        except:
> -            pass
> -
>      for util in required_utilities.split():
>          if not check_app_exists( util, e.data ):
>              missing = missing + "%s," % util




  reply	other threads:[~2011-03-02  1:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-02  1:38 [PATCH 0/6] Fixes to get oe-core building Khem Raj
2011-03-02  1:38 ` [PATCH 1/6] sqlite3: Update version 3.7.3 -> 3.7.5 Khem Raj
2011-03-02  1:48   ` Mark Hatle
2011-03-02  7:48     ` Khem Raj
2011-03-02  1:38 ` [PATCH 2/6] lib/oe/path.py: Use bb.utils.mkdirhier instead of bb.mkdirhier Khem Raj
2011-03-02  1:38 ` [PATCH 3/6] linux-libc-headers_2.6.37.2.bb: Add checksums Khem Raj
2011-03-02  1:38 ` [PATCH 4/6] distro_tracking_fields.inc: Use 2.6.37.2 instead of 2.6.36 for linux-libc-headers Khem Raj
2011-03-02  1:38 ` [PATCH 5/6] qemu-0.13.0: Add patch to avoid mmap_min_addr Khem Raj
2011-03-02  1:38 ` [PATCH 6/6] sanity.bbclass: Check for mmap_min_addr can be safely removed Khem Raj
2011-03-02  1:47   ` Mark Hatle [this message]
2011-03-02  7:43     ` Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D6DA1A1.3030409@windriver.com \
    --to=mark.hatle@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.