From: Jaehoon Chung <jh80.chung@samsung.com>
To: Will Newton <will.newton@gmail.com>
Cc: Chris Ball <cjb@laptop.org>, linux-mmc@vger.kernel.org
Subject: Re: [PATCH] mmc: dw_mmc: Remove set-but-unused variable.
Date: Wed, 02 Mar 2011 11:55:09 +0900 [thread overview]
Message-ID: <4D6DB18D.3080006@samsung.com> (raw)
In-Reply-To: <AANLkTimqBMmpT_vr+UHjkwzHGOJEKaNeUKLw0VZRnWjr@mail.gmail.com>
Acked-by: Jaehoon Chung <jh80.chung@samsung.com>
Will Newton wrote:
> On Mon, Feb 28, 2011 at 9:55 PM, Chris Ball <cjb@laptop.org> wrote:
>> count is only ever used by assigning to old_len if count == 0, and
>> then old_len isn't ever used at all. So, both are redundant. Fixes:
>>
>> drivers/mmc/host/dw_mmc.c: In function ‘dw_mci_read_data_pio’:
>> drivers/mmc/host/dw_mmc.c:1034:32: warning: variable ‘old_len’ set but
>> not used [-Wunused-but-set-variable]
>>
>> Signed-off-by: Chris Ball <cjb@laptop.org>
>> Cc: Will Newton <will.newton@imgtec.com>
>
> Looks good, thanks for fixing this!
>
> Acked-by: Will Newton <will.newton@imgtec.com>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2011-03-02 3:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-28 21:55 [PATCH] mmc: dw_mmc: Remove set-but-unused variable Chris Ball
2011-03-01 10:07 ` Will Newton
2011-03-02 2:55 ` Jaehoon Chung [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6DB18D.3080006@samsung.com \
--to=jh80.chung@samsung.com \
--cc=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=will.newton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.