All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Hatle <mark.hatle@windriver.com>
To: <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH v2 1/7] sqlite3: Update version 3.7.3 -> 3.7.5
Date: Wed, 2 Mar 2011 08:28:53 -0600	[thread overview]
Message-ID: <4D6E5425.5080107@windriver.com> (raw)
In-Reply-To: <1299055045-8096-2-git-send-email-raj.khem@gmail.com>

On 3/2/11 2:37 AM, Khem Raj wrote:
> * Imported from OE commit a2c3af2d608b1b713018d688b00e03873a538993
> * native version of 3.7.3 does not build
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta/recipes-support/sqlite/sqlite3.inc      |    7 ++++++-
>  meta/recipes-support/sqlite/sqlite3_3.7.3.bb |    8 --------
>  meta/recipes-support/sqlite/sqlite3_3.7.5.bb |   10 ++++++++++
>  3 files changed, 16 insertions(+), 9 deletions(-)
>  delete mode 100644 meta/recipes-support/sqlite/sqlite3_3.7.3.bb
>  create mode 100644 meta/recipes-support/sqlite/sqlite3_3.7.5.bb
> 
> diff --git a/meta/recipes-support/sqlite/sqlite3.inc b/meta/recipes-support/sqlite/sqlite3.inc
> index 92c4930..a5e6782 100644
> --- a/meta/recipes-support/sqlite/sqlite3.inc
> +++ b/meta/recipes-support/sqlite/sqlite3.inc
> @@ -3,7 +3,7 @@ HOMEPAGE = "http://www.sqlite.org"
>  SECTION = "libs"
>  PRIORITY = "optional"
>  DEPENDS = "readline ncurses tcl-native"
> -DEPENDS_virtclass-native = "tcl-native"
> +DEPENDS_virtclass-native = "tcl-native ncurses-native"
>  LICENSE = "PD"

Sorry, I didn't notice this before either.  Is ncurses-native and tcl-native
actually needed here?

From what I understand of sqlite, the ncurses is only used when readline is
used.  Readline during a virtclass-native build is disabled in the sqlite3.inc
file.  (Similarly tcl is also disabled in the sqlite3.inc file.)


>  SRC_URI = "http://www.sqlite.org/sqlite-${PV}.tar.gz \
> @@ -32,3 +32,8 @@ FILES_lib${PN}-doc = "${docdir} ${mandir} ${infodir}"
>  AUTO_LIBNAME_PKGS = "lib${PN}"
>  
>  BBCLASSEXTEND = "native nativesdk"
> +
> +#do_compile_prepend() {
> +#        oe_runmake sqlite3.h
> +#        install -m 0644 sqlite3.h ${STAGING_INCDIR}
> +#}

Any reason to keep this, or can we just remove the code?

> diff --git a/meta/recipes-support/sqlite/sqlite3_3.7.3.bb b/meta/recipes-support/sqlite/sqlite3_3.7.3.bb
> deleted file mode 100644
> index 7296aba..0000000
> --- a/meta/recipes-support/sqlite/sqlite3_3.7.3.bb
> +++ /dev/null
> @@ -1,8 +0,0 @@
> -require sqlite3.inc
> -
> -LIC_FILES_CHKSUM = "file://src/main.c;endline=16;md5=86c9b824e9d68f8a26343a4b57f6d85a"
> -
> -PR = "r1"
> -
> -SRC_URI[md5sum] = "5437978aae90350cf984993091e0d695"
> -SRC_URI[sha256sum] = "dbf352e8fbb74829f5e7a88f9f6ceeb80a709537f668c36e4b6cdfb271309ef6"
> diff --git a/meta/recipes-support/sqlite/sqlite3_3.7.5.bb b/meta/recipes-support/sqlite/sqlite3_3.7.5.bb
> new file mode 100644
> index 0000000..212d9e2
> --- /dev/null
> +++ b/meta/recipes-support/sqlite/sqlite3_3.7.5.bb
> @@ -0,0 +1,10 @@
> +require sqlite3.inc
> +
> +LIC_FILES_CHKSUM = "file://sqlite3.c;endline=19;md5=c1b8048b783961c3ba387c43fd955dc6"
> +
> +SRC_URI = "http://www.sqlite.org/sqlite-autoconf-3070500.tar.gz"
> +S = "${WORKDIR}/sqlite-autoconf-3070500"
> +PR = "r0"
> +
> +SRC_URI[md5sum] = "a9604a82613ade2e7f4c303f233e477f"                                                 
> +SRC_URI[sha256sum] = "cb5b86926ec9f65882b2dddd244f2d620337d911ec73411863f77e48cf6a2f94"              




  parent reply	other threads:[~2011-03-02 14:30 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-02  8:37 [PATCH V2 0/6] Fixes to get oe-core building Khem Raj
2011-03-02  8:37 ` [PATCH v2 1/7] sqlite3: Update version 3.7.3 -> 3.7.5 Khem Raj
2011-03-02  8:56   ` Koen Kooi
2011-03-02 20:35     ` Khem Raj
2011-03-02  9:48   ` Richard Purdie
2011-03-02 14:28   ` Mark Hatle [this message]
2011-03-02 20:41     ` Khem Raj
2011-03-02 22:14     ` Tom Rini
2011-03-03  5:29     ` Khem Raj
2011-03-02  8:37 ` [PATCH v2 2/7] lib/oe/path.py: Use bb.utils.mkdirhier instead of bb.mkdirhier Khem Raj
2011-03-02  8:37 ` [PATCH v2 3/7] linux-libc-headers_2.6.37.2.bb: Add checksums Khem Raj
2011-03-02  8:37 ` [PATCH v2 4/7] distro_tracking_fields.inc: Use 2.6.37.2 instead of 2.6.36 for linux-libc-headers Khem Raj
2011-03-02  8:37 ` [PATCH v2 5/7] qemu-0.13.0: Add patch to avoid mmap_min_addr Khem Raj
2011-03-02  8:37 ` [PATCH v2 6/7] gcc: Statically link in support libraries e.g. libmpfr libgmp etc Khem Raj
2011-03-02  8:37 ` [PATCH v2 7/7] sanity.bbclass: Check for /proc/sys/vm/mmap_min_addr to be >= 65536 Khem Raj
2011-03-02 22:23   ` Tom Rini
2011-03-02 23:21     ` Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D6E5425.5080107@windriver.com \
    --to=mark.hatle@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.