From: Cyrill Gorcunov <gorcunov@gmail.com>
To: David Rientjes <rientjes@google.com>
Cc: Yinghai Lu <yinghai@kernel.org>, Tejun Heo <tj@kernel.org>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
tglx@linutronix.de, brgerst@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [patch] x86, mm: Clean up initmem_init
Date: Fri, 04 Mar 2011 01:10:22 +0300 [thread overview]
Message-ID: <4D7011CE.6060306@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1103031404510.4141@chino.kir.corp.google.com>
On 03/04/2011 01:05 AM, David Rientjes wrote:
> On Thu, 3 Mar 2011, Yinghai Lu wrote:
>
>> he want
>>
>>> +#ifdef CONFIG_ACPI_NUMA
>>>>> + ret = numa_init(x86_acpi_numa_init);
>>>>> + if (!ret)
>>>>> + return;
>>>>> +#endif
>>>>> +#ifdef CONFIG_AMD_NUMA
>>>>> + ret = numa_init(amd_numa_init);
>>>>> + if (!ret)
>>>>> + return;
>>>>> +#endif
>>
>> to be replaced by:
>>
>>> +#ifdef CONFIG_ACPI_NUMA
>>>>> + if (!numa_init(x86_acpi_numa_init))
>>>>> + return;
>>>>> +#endif
>>>>> +#ifdef CONFIG_AMD_NUMA
>>>>> + if (!numa_init(amd_numa_init))
>>>>> + return;
>>>>> +#endif
>
> It's a matter of style and I think it's up to Ingo what he'd prefer to
> see.
i'm fine with either, just though it would shrink the code a bit (since there
is no need to track var witch i guess will be eliminated by gcc anyway).
nb: am i only the one who obtain bounce from shaohui.zheng@intel.com (so i'd to remove
him from cc'ing)?
--
Cyrill
next prev parent reply other threads:[~2011-03-03 22:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tip-ffe77a4605fb2588f8666850ad3e3b196241658f@git.kernel.org>
2011-02-20 3:34 ` [tip:x86/mm] x86-64, NUMA: Restructure initmem_init() David Rientjes
2011-02-21 8:35 ` Tejun Heo
2011-03-03 21:15 ` [patch] x86, mm: Clean up initmem_init David Rientjes
2011-03-03 21:43 ` Cyrill Gorcunov
2011-03-03 22:00 ` David Rientjes
2011-03-03 22:03 ` Yinghai Lu
2011-03-03 22:05 ` Cyrill Gorcunov
2011-03-03 22:05 ` David Rientjes
2011-03-03 22:10 ` Cyrill Gorcunov [this message]
2011-03-04 7:08 ` Ingo Molnar
2011-03-04 12:38 ` Cyrill Gorcunov
2011-03-04 10:16 ` Tejun Heo
2011-03-04 14:19 ` [PATCH x86/mm] x86-64, NUMA: Clean up initmem_init() Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D7011CE.6060306@gmail.com \
--to=gorcunov@gmail.com \
--cc=brgerst@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.