All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Lambert <dave@lambsys.com>
To: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Subject: Bug in mtd_speedtest?
Date: Thu, 03 Mar 2011 17:45:18 -0600	[thread overview]
Message-ID: <4D70280E.8030501@lambsys.com> (raw)

I think I may have found an overflow condition in the speed calculation 
of mtd_speedtest on some platforms with larger flash partitions:

Consider for example if goodebcnt = 15000, and mtd->erasesize = 
256*1024, then there is an intermediate product of  3932160000 which 
results in the sign bit being set on a 32 bit integer. Maybe k should be 
an unsigned long long?

.....
static long calc_speed(void)
{
     long ms, k, speed;

     ms = (finish.tv_sec - start.tv_sec) * 1000 +
          (finish.tv_usec - start.tv_usec) / 1000;
     k = goodebcnt * mtd->erasesize / 1024;
     speed = (k * 1000) / ms;
     return speed;
}
.....

             reply	other threads:[~2011-03-03 23:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-03 23:45 David Lambert [this message]
2011-03-04  6:59 ` Bug in mtd_speedtest? Artem Bityutskiy
2011-03-04 17:53   ` David Lambert
2011-03-07  4:11     ` Jon Povey
2011-03-07 10:09     ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D70280E.8030501@lambsys.com \
    --to=dave@lambsys.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.