From: Caspar Zhang <czhang@redhat.com>
To: Garrett Cooper <yanegomi@gmail.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH v2] syscalls: getdents0[234]: add tst_exit()
Date: Fri, 04 Mar 2011 17:31:40 +0800 [thread overview]
Message-ID: <4D70B17C.6010202@redhat.com> (raw)
In-Reply-To: <AANLkTimspgQ+vhic29iSFrcWyXjT88WjKVvXY8uRELo0@mail.gmail.com>
On 03/04/2011 05:27 PM, Garrett Cooper wrote:
> On Fri, Mar 4, 2011 at 12:52 AM, Caspar Zhang <czhang@redhat.com> wrote:
>> On 03/04/2011 04:37 PM, Cristian Greco wrote:
>>> wouldn't it be better to call tst_resm() with TCONF instead of TINFO,
>>> for the sake of consistency?
>>
>> Agree. Updated to v3:
>>
>> These tests contain x86 asm so that they wouldn't be run on x86_64
>> machine, but run into a simple main() functions instead. However all of
>> them are missing tst_exit() which could result in a exit_code=10
>> failure.
>
> Fixing it with equivalent:
>
> tst_brkm(TBROK, NULL, ...);
TBROK returns a non-zero value, which may result in a FAIL in log...
Caspar
>
> Thanks,
> -Garrett
--
Quality Engineer (Kernel) in
Red Hat Software (Beijing) Co., R&D Branch
http://www.cn.redhat.com/
TEL: +86-10-62608150
------------------------------------------------------------------------------
What You Don't Know About Data Connectivity CAN Hurt You
This paper provides an overview of data connectivity, details
its effect on application quality, and explores various alternative
solutions. http://p.sf.net/sfu/progress-d2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2011-03-04 9:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-03 17:37 [LTP] [PATCH] syscalls: getdents02: add tst_exit() Caspar Zhang
2011-03-03 17:51 ` [LTP] [PATCH v2] syscalls: getdents0[234]: " Caspar Zhang
2011-03-04 8:37 ` Cristian Greco
2011-03-04 8:52 ` Caspar Zhang
2011-03-04 9:27 ` Garrett Cooper
2011-03-04 9:31 ` Caspar Zhang [this message]
2011-03-04 10:14 ` Garrett Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D70B17C.6010202@redhat.com \
--to=czhang@redhat.com \
--cc=ltp-list@lists.sourceforge.net \
--cc=yanegomi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.