From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Hannes Reinecke <hare@suse.de>
Cc: Tejun Heo <tj@kernel.org>, jgarzik@pobox.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: Include WWN ID in inquiry VPD emulation
Date: Fri, 04 Mar 2011 14:17:12 +0300 [thread overview]
Message-ID: <4D70CA38.5000904@ru.mvista.com> (raw)
In-Reply-To: <20110304085501.8B331F90E1@ochil.suse.de>
Hello.
On 04-03-2011 11:55, Hannes Reinecke wrote:
> As per SAT-3 the WWN ID should be included in the VPD page 0x83
> (device identification) emulation.
> Signed-off-by: Hannes Reinecke<hare@suse.de>
[...]
> diff --git a/include/linux/ata.h b/include/linux/ata.h
> index 0c4929f..f62463e 100644
> --- a/include/linux/ata.h
> +++ b/include/linux/ata.h
[...]
> @@ -815,6 +817,13 @@ static inline int ata_id_has_unload(const u16 *id)
> return 0;
> }
>
> +static inline int ata_id_has_wwn(const u16 *id)
> +{
> + if ((id[ATA_ID_CSF_DEFAULT] & 0xC000) != 0x4000)
> + return 0;
> + return id[ATA_ID_CSF_DEFAULT] & (1 << 8);
Could be compacted to:
return (id[ATA_ID_CSF_DEFAULT] & 0xC100) == 0x4100;
WBR, Sergei
next prev parent reply other threads:[~2011-03-04 11:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-04 8:55 [PATCH] libata: Include WWN ID in inquiry VPD emulation Hannes Reinecke
2011-03-04 11:17 ` Sergei Shtylyov [this message]
2011-03-04 11:36 ` Hannes Reinecke
2011-03-04 17:09 ` Tejun Heo
2011-03-04 17:22 ` Jeff Garzik
2011-03-07 7:57 ` Hannes Reinecke
2011-03-07 8:27 ` Jeff Garzik
2011-03-07 8:53 ` Hannes Reinecke
2011-03-14 7:01 ` Jeff Garzik
2011-03-14 15:56 ` Hannes Reinecke
-- strict thread matches above, loose matches on Subject: below --
2011-03-07 7:56 Hannes Reinecke
2011-03-14 7:00 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D70CA38.5000904@ru.mvista.com \
--to=sshtylyov@mvista.com \
--cc=hare@suse.de \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.