From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-px0-f176.google.com (mail-px0-f176.google.com [209.85.212.176]) by mx1.pokylinux.org (Postfix) with ESMTP id 498054C800A3 for ; Fri, 4 Mar 2011 10:33:57 -0600 (CST) Authentication-Results: mx1.pokylinux.org; dkim=pass (1024-bit key; insecure key) header.i=@gmail.com; x-dkim-adsp=none (insecure policy) Received: by pxi11 with SMTP id 11so444181pxi.35 for ; Fri, 04 Mar 2011 08:33:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=79O9SfWdbYJBBAQj8ANDhWF+8SaraLXiRr+oyVg5ETY=; b=TvznJHK6WFoB27aQNAyMjbBTyddg0S5F5XYQlbOnk9Y6jndo6ViVvHiQUpfB0st42K 7UY5YeioW7xR777BccnOB0Z43PvETluvF8lxQP0BnhAiNGnuJo5t0dokbcP+3oau8fSr ONN75UCFUY9Z9byavirKS60QMjKnypMbez7T8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=hFMSsaljTI1OhGuGb7VAGIJM2wzLHrz706UN2hjfuxzOkB7ZiQyBb1Xsa1RwjvRafA SX4IYLM28mJyGuSWO3yfWnTOI+ynJT1UnGq/YSj5mtlWdkxSbVqOFbGgh6IuRUY711bT i8Lua0B2egFruXrwHDkREY53BUHwAhrsDnI78= Received: by 10.142.202.18 with SMTP id z18mr515397wff.438.1299256436288; Fri, 04 Mar 2011 08:33:56 -0800 (PST) Received: from [192.168.1.70] (99-57-141-118.lightspeed.sntcca.sbcglobal.net [99.57.141.118]) by mx.google.com with ESMTPS id 25sm3173314wfb.10.2011.03.04.08.33.54 (version=SSLv3 cipher=OTHER); Fri, 04 Mar 2011 08:33:55 -0800 (PST) Message-ID: <4D711471.104@gmail.com> Date: Fri, 04 Mar 2011 08:33:53 -0800 From: Khem Raj User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.14) Gecko/20110221 Thunderbird/3.1.8 MIME-Version: 1.0 To: Yu Ke References: <81b14a20bb1ed302b6befc872535c35659c57725.1299247293.git.ke.yu@intel.com> In-Reply-To: <81b14a20bb1ed302b6befc872535c35659c57725.1299247293.git.ke.yu@intel.com> Cc: poky@yoctoproject.org Subject: Re: [PATCH 1/1] x11vnc: fix the endian issue in mips for bug 782 X-BeenThere: poky@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Poky build system developer discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Mar 2011 16:34:02 -0000 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/4/2011 6:04 AM, Yu Ke wrote: > x11vnc use LIBVNCSERVER_WORDS_BIGENDIAN to handle the endian, however > it is not set correctly when cross-compile for mips, thus x11vnc mips > does not work correctly. > > meanwhile, x11vnc has the autconf macro AC_C_BIGENDIAN which can > handle the endian correctly. so this patch replace the > LIBVNCSERVER_WORDS_BIGENDIAN with WORDS_BIGENDIAN (generated by > AC_C_BIGENDIAN) to fix this issue. > > this patch fix the bug [YOCTO #782] > > this appraoch is suggested by Khem Raj > > CC: Khem Raj > > Signed-off-by: Yu Ke look better > --- > .../recipes-graphics/x11vnc/files/endian-fix.patch | 22 ++++++++++++++++++++ > meta/recipes-graphics/x11vnc/x11vnc_0.9.12.bb | 5 +++- > 2 files changed, 26 insertions(+), 1 deletions(-) > create mode 100644 meta/recipes-graphics/x11vnc/files/endian-fix.patch > > diff --git a/meta/recipes-graphics/x11vnc/files/endian-fix.patch b/meta/recipes-graphics/x11vnc/files/endian-fix.patch > new file mode 100644 > index 0000000..0b5e470 > --- /dev/null > +++ b/meta/recipes-graphics/x11vnc/files/endian-fix.patch > @@ -0,0 +1,22 @@ > +libvncserver: replace LIBVNCSERVER_WORDS_BIGENDIAN with WORDS_BIGENDIAN > + > +since macro AC_C_BIGENDIAN is used in autoconf and WORDS_BIGENDIAN is > +automatically set for different arch, it is better to use WORDS_BIGENDIAN > +instead of LIBVNCSERVER_WORDS_BIGENDIAN, which cuase issue in mips. > + > +Signed-off-by: Yu Ke > + > +diff --git a/libvncserver/main.c b/libvncserver/main.c > +index b6bd930..8bbb7bf 100644 > +--- a/libvncserver/main.c > ++++ b/libvncserver/main.c > +@@ -47,7 +47,7 @@ static MUTEX(extMutex); > + > + static int rfbEnableLogging=1; > + > +-#ifdef LIBVNCSERVER_WORDS_BIGENDIAN > ++#ifdef WORDS_BIGENDIAN > + char rfbEndianTest = (1==0); > + #else > + char rfbEndianTest = (1==1); > + > diff --git a/meta/recipes-graphics/x11vnc/x11vnc_0.9.12.bb b/meta/recipes-graphics/x11vnc/x11vnc_0.9.12.bb > index f5a6662..f92eb49 100644 > --- a/meta/recipes-graphics/x11vnc/x11vnc_0.9.12.bb > +++ b/meta/recipes-graphics/x11vnc/x11vnc_0.9.12.bb > @@ -9,8 +9,11 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=361b6b837cad26c6900a926b62aada5f \ > > DEPENDS = "openssl virtual/libx11 libxext avahi jpeg zlib" > > +PR = "r1" > + > SRC_URI = "${SOURCEFORGE_MIRROR}/libvncserver/x11vnc-${PV}.tar.gz\ > - file://starting-fix.patch" > + file://starting-fix.patch \ > + file://endian-fix.patch " > > SRC_URI[md5sum] = "1498a68d02aa7b6c97bf746c073c8d00" > SRC_URI[sha256sum] = "60a7cceee2c9a5f1c854340b2bae13f975ac55906237042f81f795b28a154a79"