Re: [PATCH] mrouted-3.9.4: intitial recipe

[Andreas Oberritter <obi@opendreambox.org>]

On 03/04/2011 07:45 PM, Tom Rini wrote:
> On 03/04/2011 09:14 AM, Paul Menzel wrote:
>> Am Freitag, den 04.03.2011, 07:40 -0800 schrieb Khem Raj:
>>> On 3/4/2011 5:12 AM, Andreas Oberritter wrote:
>>>> Signed-off-by: Andreas Oberritter<obi@opendreambox.org>
>>>> ---
>>>> This was only compile-tested. It would be nice to get some feedback.
>>>
>>> Looks ok to me. Does it need any deps? May be building it from scratch
>>> will detect it if not otherwise
>>>
>>> Acked-by: Khem Raj<raj.khem@gmail.com>
>>
>> With the dependencies addressed and …
>>
>>>>    recipes/mrouted/mrouted_3.9.4.bb |   23 +++++++++++++++++++++++
>>>>    1 files changed, 23 insertions(+), 0 deletions(-)
>>>>    create mode 100644 recipes/mrouted/mrouted_3.9.4.bb
>>>>
>>>> diff --git a/recipes/mrouted/mrouted_3.9.4.bb
>>>> b/recipes/mrouted/mrouted_3.9.4.bb
>>>> new file mode 100644
>>>> index 0000000..4ba4111
>>>> --- /dev/null
>>>> +++ b/recipes/mrouted/mrouted_3.9.4.bb
>>>> @@ -0,0 +1,23 @@
>>>> +DESCRIPTION = "DVMRP multicast routing daemon"
>>>> +HOMEPAGE = "http://troglobit.com/mrouted.shtml"
>>>> +SECTION = "network"
>>>> +LICENSE = "BSD"
>>>> +
>>>> +SRC_URI =
>>>> "ftp://ftp.vmlinux.org/pub/People/jocke/mrouted/mrouted-${PV}.tar.bz2"
>>>> +SRC_URI[md5sum] = "688b74fc42919d588f262e6b3c9c6d4c"
>>>> +SRC_URI[sha256sum] =
>>>> "c697549b2e506a380575f7adb67e87288ef2295b97241b3a1aeb0e88b827a3e1"
>>>> +
>>>> +EXTRA_OEMAKE = " \
>>>> +        datadir=${datadir} \
>>>> +        mandir=${mandir} \
>>>> +        prefix=${prefix} \
>>>> +        sysconfdir=${sysconfdir} \
>>>> +        DESTDIR=${D} \
>>>> +"
>>>> +
>>>> +do_compile() {
>>>> +        oe_runmake
>>>> +}
>>
>> … add a blank line (?) this is
>>
>> Acked-by: Paul Menzel<paulepanter@users.sourceforge.net>
> 
> Well, we don't need a do_compile since that's just a smaller copy of
> base_do_compile :)

Right. How about adding base_do_install with similar semantics? With
packaged staging, can any recipe be useful without an install rule?

>>>> +do_install() {
>>>> +        oe_runmake install
>>>> +}