All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Tejun Heo <tj@kernel.org>
Cc: Stephen Clark <sclark46@earthlink.net>,
	Mark Lord <kernel@teksavvy.com>, Krzysztof Halasa <khc@pm.waw.pl>,
	linux-ide@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
	linux-scsi@vger.kernel.org,
	James Bottomley <James.Bottomley@HansenPartnership.com>
Subject: Re: NEC ND-4550A problems reading DVD-R
Date: Fri, 04 Mar 2011 23:16:46 +0100	[thread overview]
Message-ID: <4D7164CE.80009@kernel.dk> (raw)
In-Reply-To: <20110304110757.GJ20499@htj.dyndns.org>

On 2011-03-04 12:07, Tejun Heo wrote:
> (cc'ing Jens and James)
> 
> On Tue, Mar 01, 2011 at 10:47:41AM -0500, Stephen Clark wrote:
>> On 03/01/2011 08:48 AM, Mark Lord wrote:
>>> On 11-03-01 03:01 AM, Tejun Heo wrote:
>>> ..
>>>> I think that's determined by drivers/scsi/sr.h::SR_TIMEOUT which is
>>>> hardcoded to be 30 seconds.  Maybe it's better to move it to use the
>>>> block parameter.  Anyways, the drive actually takes longer than 30secs
>>>> to recognize the media?
>>> That slow behaviour is not uncommon, especially as drives struggle
>>> to recognize various forms of copy-protected media (DVD-Video).
>>> A longer default, or tuneable timeout, would help.
>>
>> I agree with Mark, this should be a user tuneable value. My 2006 LG
>> dvd-rw frequently times out
>> trying to identify the media. But after numerous timeout error
>> messages it usually suceeds.
> 
> I don't think it should be a user tunable value.  It should be
> something automatic.  I mean, how many would know to go some cryptic
> place and increase sr probing timeout?
> 
> At the same time, increasing it for other cases is quite unattractive,
> so it probably would be a good idea to only use higher timeout value
> for the TUR right after media presence change event.
> 
> Anyone interested in doing it?

A higher timeout would be the easy fix. And unless there's a solid way
to detect whether the drive is truly hung or just busy trying to grok
the media, I think it's the only feasible solution.

-- 
Jens Axboe


      parent reply	other threads:[~2011-03-04 22:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-28 21:36 NEC ND-4550A problems reading DVD-R Krzysztof Halasa
2011-03-01  8:01 ` Tejun Heo
2011-03-01 10:01   ` Krzysztof Halasa
2011-03-01 13:48   ` Mark Lord
2011-03-01 15:47     ` Stephen Clark
2011-03-04 11:07       ` Tejun Heo
2011-03-04 14:09         ` Stephen Clark
2011-03-04 22:16         ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D7164CE.80009@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=kernel@teksavvy.com \
    --cc=khc@pm.waw.pl \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=sclark46@earthlink.net \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.