From: Bryan Huntsman <bryanh@codeaurora.org>
To: Sheetal Sahasrabudhe <sheetals@codeaurora.org>
Cc: linux-arm-kernel@lists.infradead.org, will.deacon@arm.com,
jamie.iles@picochip.com, jean.pihet@newoldbits.com,
robert.richter@amd.com, dwalker@fifo99.com,
davidb@codeaurora.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] ARM: Add Scorpion/ScorpionMP support to perf and Oprofile
Date: Fri, 04 Mar 2011 14:42:29 -0800 [thread overview]
Message-ID: <4D716AD5.1070403@codeaurora.org> (raw)
In-Reply-To: <1299276551-11978-1-git-send-email-sheetals@codeaurora.org>
On 03/04/2011 02:09 PM, Sheetal Sahasrabudhe wrote:
> This patchset contains the following features:
> It adds support for Qualcomm Scorpion and ScorpionMP processors to perfevents
> and Oprofile.
> It adds PMU support for Scorpion and ScorpionMP.
> It also updates PMU IRQ identifiers for various Scorpion and ScorpionMP targets.
>
> Sheetal Sahasrabudhe (3):
> msm: Add support for Scorpion and ScorpionMP PMU
> [ARM] perfevents: Add support for Scorpion performance monitors
> [ARM] Oprofile: Add Qualcomm Scorpion and ScorpionMP CPU type
>
> arch/arm/include/asm/perf_event.h | 2 +
> arch/arm/kernel/perf_event.c | 11 +
> arch/arm/kernel/perf_event_qc.c | 677 ++++++++++++++++++++++++++++
> arch/arm/mach-msm/Makefile | 2 +
> arch/arm/mach-msm/include/mach/irqs-7x30.h | 2 +-
> arch/arm/mach-msm/include/mach/irqs-8960.h | 2 +-
> arch/arm/mach-msm/include/mach/irqs-8x50.h | 2 +-
> arch/arm/mach-msm/include/mach/irqs-8x60.h | 2 +-
> arch/arm/mach-msm/pmu.c | 36 ++
> arch/arm/oprofile/common.c | 4 +
> 10 files changed, 736 insertions(+), 4 deletions(-)
> create mode 100644 arch/arm/kernel/perf_event_qc.c
> create mode 100644 arch/arm/mach-msm/pmu.c
>
Some minor comments from a quick review:
- you're using multi-line commenting style for single line comments
- see Documentation/CodingStyle, Chapter 8, for preferred multi-line
commenting style
- 'mv perf_event_qc.c perf_event_msm.c'?
- Bryan
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
WARNING: multiple messages have this Message-ID (diff)
From: bryanh@codeaurora.org (Bryan Huntsman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/3] ARM: Add Scorpion/ScorpionMP support to perf and Oprofile
Date: Fri, 04 Mar 2011 14:42:29 -0800 [thread overview]
Message-ID: <4D716AD5.1070403@codeaurora.org> (raw)
In-Reply-To: <1299276551-11978-1-git-send-email-sheetals@codeaurora.org>
On 03/04/2011 02:09 PM, Sheetal Sahasrabudhe wrote:
> This patchset contains the following features:
> It adds support for Qualcomm Scorpion and ScorpionMP processors to perfevents
> and Oprofile.
> It adds PMU support for Scorpion and ScorpionMP.
> It also updates PMU IRQ identifiers for various Scorpion and ScorpionMP targets.
>
> Sheetal Sahasrabudhe (3):
> msm: Add support for Scorpion and ScorpionMP PMU
> [ARM] perfevents: Add support for Scorpion performance monitors
> [ARM] Oprofile: Add Qualcomm Scorpion and ScorpionMP CPU type
>
> arch/arm/include/asm/perf_event.h | 2 +
> arch/arm/kernel/perf_event.c | 11 +
> arch/arm/kernel/perf_event_qc.c | 677 ++++++++++++++++++++++++++++
> arch/arm/mach-msm/Makefile | 2 +
> arch/arm/mach-msm/include/mach/irqs-7x30.h | 2 +-
> arch/arm/mach-msm/include/mach/irqs-8960.h | 2 +-
> arch/arm/mach-msm/include/mach/irqs-8x50.h | 2 +-
> arch/arm/mach-msm/include/mach/irqs-8x60.h | 2 +-
> arch/arm/mach-msm/pmu.c | 36 ++
> arch/arm/oprofile/common.c | 4 +
> 10 files changed, 736 insertions(+), 4 deletions(-)
> create mode 100644 arch/arm/kernel/perf_event_qc.c
> create mode 100644 arch/arm/mach-msm/pmu.c
>
Some minor comments from a quick review:
- you're using multi-line commenting style for single line comments
- see Documentation/CodingStyle, Chapter 8, for preferred multi-line
commenting style
- 'mv perf_event_qc.c perf_event_msm.c'?
- Bryan
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2011-03-04 22:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-04 22:09 [PATCH 0/3] ARM: Add Scorpion/ScorpionMP support to perf and Oprofile Sheetal Sahasrabudhe
2011-03-04 22:09 ` Sheetal Sahasrabudhe
2011-03-04 22:42 ` Bryan Huntsman [this message]
2011-03-04 22:42 ` Bryan Huntsman
2011-03-05 21:40 ` Sheetal Sahasrabudhe
2011-03-05 21:40 ` Sheetal Sahasrabudhe
2011-03-05 21:40 ` Sheetal Sahasrabudhe
2011-03-07 10:06 ` Jean Pihet
2011-03-07 10:06 ` Jean Pihet
2011-03-07 10:06 ` Jean Pihet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D716AD5.1070403@codeaurora.org \
--to=bryanh@codeaurora.org \
--cc=davidb@codeaurora.org \
--cc=dwalker@fifo99.com \
--cc=jamie.iles@picochip.com \
--cc=jean.pihet@newoldbits.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robert.richter@amd.com \
--cc=sheetals@codeaurora.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.