From mboxrd@z Thu Jan 1 00:00:00 1970 From: Trilok Soni Subject: Re: [PATCH 1/3] msm: Add support for Scorpion and ScorpionMP PMU Date: Sat, 05 Mar 2011 14:13:12 +0530 Message-ID: <4D71F7A0.5010101@codeaurora.org> References: <1299276583-12542-1-git-send-email-sheetals@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:13928 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750755Ab1CEInd (ORCPT ); Sat, 5 Mar 2011 03:43:33 -0500 In-Reply-To: <1299276583-12542-1-git-send-email-sheetals@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Sheetal Sahasrabudhe Cc: linux-arm-kernel@lists.infradead.org, will.deacon@arm.com, dwalker@fifo99.com, bryanh@codeaurora.org, davidb@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Hi Sheetal, > +static int __init scorpion_pmu_init(void) > +{ > + platform_device_register(&pmu_device); platform_device_register can fail. Better do it like "return platform_device_register(&pmu_device); ---Trilok Soni -- Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. From mboxrd@z Thu Jan 1 00:00:00 1970 From: tsoni@codeaurora.org (Trilok Soni) Date: Sat, 05 Mar 2011 14:13:12 +0530 Subject: [PATCH 1/3] msm: Add support for Scorpion and ScorpionMP PMU In-Reply-To: <1299276583-12542-1-git-send-email-sheetals@codeaurora.org> References: <1299276583-12542-1-git-send-email-sheetals@codeaurora.org> Message-ID: <4D71F7A0.5010101@codeaurora.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Sheetal, > +static int __init scorpion_pmu_init(void) > +{ > + platform_device_register(&pmu_device); platform_device_register can fail. Better do it like "return platform_device_register(&pmu_device); ---Trilok Soni -- Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.