From: Gerald Van Baren <vanbaren@cideas.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCHv2] fdt_support: Fix buffer overflow in fdt_fixup_memory_banks
Date: Sat, 05 Mar 2011 23:09:28 -0500 [thread overview]
Message-ID: <4D7308F8.7020501@cideas.com> (raw)
In-Reply-To: <1298477904-21221-1-git-send-email-Kyle.D.Moffett@boeing.com>
Dear Wolfgang,
Can you apply this patch for me? Otherwise I'll apply it to my repo and
send a pull request.
Acked-by: Gerald Van Baren <vanbaren@cideas.com>
Thanks,
gvb
On 02/23/2011 11:18 AM, Kyle Moffett wrote:
> When fdt_fixup_memory_banks is called with 2-cell address and size
> fields in the device-tree (IE: 64-bit address and size), then it will
> overflow its on-stack "tmp" buffer.
>
> This fixes the buffer size and adds a comment explaining how many bytes
> need to be allocated per record.
>
> Signed-off-by: Kyle Moffett<Kyle.D.Moffett@boeing.com>
> Cc: Jerry Van Baren<vanbaren@cideas.com>
> ---
> Changelog:
> v2: Resubmitted separately from the other HWW-1U-1A changes.
>
> common/fdt_support.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/common/fdt_support.c b/common/fdt_support.c
> index 6c98e5b..edcf04a 100644
> --- a/common/fdt_support.c
> +++ b/common/fdt_support.c
> @@ -394,7 +394,7 @@ int fdt_fixup_memory_banks(void *blob, u64 start[], u64 size[], int banks)
> {
> int err, nodeoffset;
> int addr_cell_len, size_cell_len, len;
> - u8 tmp[banks * 8];
> + u8 tmp[banks * 16]; /* Up to 64-bit address + 64-bit size */
> int bank;
>
> err = fdt_check_header(blob);
next prev parent reply other threads:[~2011-03-06 4:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-23 16:18 [U-Boot] [PATCHv2] fdt_support: Fix buffer overflow in fdt_fixup_memory_banks Kyle Moffett
2011-03-06 4:09 ` Gerald Van Baren [this message]
2011-04-05 13:30 ` Jerry Van Baren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D7308F8.7020501@cideas.com \
--to=vanbaren@cideas.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.