From: Avi Kivity <avi@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: Francis Moreau <francis.moro@gmail.com>, kvm@vger.kernel.org
Subject: Re: 2.6.38-rc6: general protection error inside KVM 64 bits guest
Date: Sun, 06 Mar 2011 17:02:02 +0200 [thread overview]
Message-ID: <4D73A1EA.1060702@redhat.com> (raw)
In-Reply-To: <20110306143503.GD25565@redhat.com>
On 03/06/2011 04:35 PM, Gleb Natapov wrote:
> > >+ r = ops->read_std(base + 102,&io_bitmap_ptr, 2, ctxt->vcpu, NULL);
> > > if (r != X86EMUL_CONTINUE)
> > > return false;
> >
> > Note: if we get a fault here, we ought to propagate it. Only
> > happens if there's a race, since the cpu checks for these
> > exceptions.
> >
> Do you mean we need to propagate fault that read_std() returns and not
> always inject GP like we do now?
Yes, it could be a #PF (or #TS or #NPF).
(for #TS we need additional logic... will this arch never end?)
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-03-06 15:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-05 9:40 2.6.38-rc6: general protection error inside KVM 64 bits guest Francis Moreau
2011-03-06 12:42 ` Gleb Natapov
2011-03-06 12:55 ` Avi Kivity
2011-03-06 14:35 ` Gleb Natapov
2011-03-06 15:02 ` Avi Kivity [this message]
2011-03-06 15:08 ` Avi Kivity
2011-03-09 7:05 ` Francis Moreau
2011-03-09 9:25 ` Gleb Natapov
2011-03-09 9:26 ` Avi Kivity
2011-03-09 9:28 ` Francis Moreau
2011-03-09 9:29 ` Avi Kivity
2011-03-09 9:30 ` Francis Moreau
2011-03-09 9:32 ` Gleb Natapov
2011-03-09 10:03 ` Avi Kivity
2011-03-09 10:07 ` Francis Moreau
2011-05-27 10:22 ` Francis Moreau
2011-05-27 12:48 ` Gleb Natapov
2011-05-27 14:30 ` Francis Moreau
2011-03-06 19:36 ` Francis Moreau
-- strict thread matches above, loose matches on Subject: below --
2011-03-04 14:50 Francis Moreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D73A1EA.1060702@redhat.com \
--to=avi@redhat.com \
--cc=francis.moro@gmail.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.