From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=35088 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PwJZW-00014h-Ph
	for qemu-devel@nongnu.org; Sun, 06 Mar 2011 14:24:55 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1PwJZS-0006kZ-FU
	for qemu-devel@nongnu.org; Sun, 06 Mar 2011 14:24:51 -0500
Received: from moutng.kundenserver.de ([212.227.126.171]:54358)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1PwJZS-0006kQ-38
	for qemu-devel@nongnu.org; Sun, 06 Mar 2011 14:24:50 -0500
Message-ID: <4D73DF7C.2060903@mail.berlios.de>
Date: Sun, 06 Mar 2011 20:24:44 +0100
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] WIN32: Add missing include for
	'struct	timeval', used in vnc.h
References: <1299417793-1720-1-git-send-email-hpoussin@reactos.org>
	<AANLkTinQVETgX-23JNaM4qJLDH6t8nVDC9yUiNV37Ent@mail.gmail.com>
In-Reply-To: <AANLkTinQVETgX-23JNaM4qJLDH6t8nVDC9yUiNV37Ent@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Herve Poussineau <hpoussin@reactos.org>, qemu-devel@nongnu.org, Roy Tam <roytam@gmail.com>

Am 06.03.2011 15:24, schrieb Roy Tam:
> Hi,
>
> 2011/3/6 Herve Poussineau<hpoussin@reactos.org>:
>
> FYI:
> [PATCH 1/3] w32: Add new directory hierarchy for MinGW extensions
> http://www.mail-archive.com/qemu-devel@nongnu.org/msg56858.html
> [PATCH 2/3] w32: Add macro timersub to sys/time.h
> http://www.mail-archive.com/qemu-devel@nongnu.org/msg56859.html
> [PATCH 3/3] osdep: Remove conditional compilation (fixes w32 compilation)
> http://www.mail-archive.com/qemu-devel@nongnu.org/msg56860.html

Yes, this patch series also addresses the same problem (and one more)
in a better way: it did not add code, but removed a conditional compilation.
(my first try was identical to Herve's patch).

Stefan

>> From: Hervé Poussineau<hpoussin@reactos.org>
>>
>>
>> Signed-off-by: Hervé Poussineau<hpoussin@reactos.org>
>> ---
>>   qemu-common.h |    1 +
>>   1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/qemu-common.h b/qemu-common.h
>> index 40dad52..18e648f 100644
>> --- a/qemu-common.h
>> +++ b/qemu-common.h
>> @@ -33,6 +33,7 @@ typedef struct DeviceState DeviceState;
>>   #include<unistd.h>
>>   #include<fcntl.h>
>>   #include<sys/stat.h>
>> +#include<sys/time.h>
>>   #include<assert.h>
>>
>>   #ifndef O_LARGEFILE
>> --
>> 1.6.0.2.GIT
>>
>>
>>