From: Stefan Weil <weil@mail.berlios.de>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Herve Poussineau <hpoussin@reactos.org>,
qemu-devel@nongnu.org, Roy Tam <roytam@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] WIN32: Add missing include for 'struct timeval', used in vnc.h
Date: Sun, 06 Mar 2011 22:18:21 +0100 [thread overview]
Message-ID: <4D73FA1D.8040708@mail.berlios.de> (raw)
In-Reply-To: <AANLkTinnPSEMkc=G5K9e2fVrQ-fZj5b1Cm+hOOGFu9iq@mail.gmail.com>
Am 06.03.2011 21:25, schrieb Blue Swirl:
> On Sun, Mar 6, 2011 at 9:24 PM, Stefan Weil<weil@mail.berlios.de> wrote:
>> Am 06.03.2011 15:24, schrieb Roy Tam:
>>> Hi,
>>>
>>> 2011/3/6 Herve Poussineau<hpoussin@reactos.org>:
>>>
>>> FYI:
>>> [PATCH 1/3] w32: Add new directory hierarchy for MinGW extensions
>>> http://www.mail-archive.com/qemu-devel@nongnu.org/msg56858.html
>>> [PATCH 2/3] w32: Add macro timersub to sys/time.h
>>> http://www.mail-archive.com/qemu-devel@nongnu.org/msg56859.html
>>> [PATCH 3/3] osdep: Remove conditional compilation (fixes w32 compilation)
>>> http://www.mail-archive.com/qemu-devel@nongnu.org/msg56860.html
>> Yes, this patch series also addresses the same problem (and one more)
>> in a better way: it did not add code, but removed a conditional compilation.
>> (my first try was identical to Herve's patch).
> As I replied to those, there are several problems with your approach.
> Wrapping timersub() would solve the other problem nicely.
>
> If we'd want to fake a POSIX-like programming environment, there are
> other approaches like gnulib. But so far, the approach has been using
> wrappers.
Obviously I missed your reply, but I just read it.
Patch 3/3 does not conflict with your intension.
It is still a better solution to include sys/time.h
and can be applied independent of the other
two patches.
prev parent reply other threads:[~2011-03-06 21:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-06 13:23 [Qemu-devel] [PATCH] WIN32: Add missing include for 'struct timeval', used in vnc.h Herve Poussineau
2011-03-06 14:22 ` Blue Swirl
2011-03-06 14:24 ` Roy Tam
2011-03-06 19:24 ` Stefan Weil
2011-03-06 20:25 ` Blue Swirl
2011-03-06 21:18 ` Stefan Weil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D73FA1D.8040708@mail.berlios.de \
--to=weil@mail.berlios.de \
--cc=blauwirbel@gmail.com \
--cc=hpoussin@reactos.org \
--cc=qemu-devel@nongnu.org \
--cc=roytam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.