From: Ryan Mallon <ryan@bluewatersys.com>
To: Alexander Sverdlin <subaparts@yandex.ru>
Cc: alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] ASoC: Remove warnings in ep93xx-i2s.c
Date: Mon, 07 Mar 2011 11:05:51 +1300 [thread overview]
Message-ID: <4D74053F.4010003@bluewatersys.com> (raw)
In-Reply-To: <1299286652.27359.108.camel@r60e>
On 03/05/2011 01:57 PM, Alexander Sverdlin wrote:
> From: Alexander Sverdlin <subaparts@yandex.ru>
>
> Remove warnings in ep93xx-i2s.c
>
> Signed-off-by: Alexander Sverdlin <subaparts@yandex.ru>
Acked-by: Ryan Mallon <ryan@bluewatersys.com>
> ---
> sound/soc/ep93xx/ep93xx-i2s.c | 8 ++++++--
> 1 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/ep93xx/ep93xx-i2s.c b/sound/soc/ep93xx/ep93xx-i2s.c
> index 3d4c086..042f4e9 100644
> --- a/sound/soc/ep93xx/ep93xx-i2s.c
> +++ b/sound/soc/ep93xx/ep93xx-i2s.c
> @@ -313,10 +313,12 @@ static int ep93xx_i2s_suspend(struct snd_soc_dai *dai)
> struct ep93xx_i2s_info *info = snd_soc_dai_get_drvdata(dai);
>
> if (!dai->active)
> - return;
> + return 0;
>
> ep93xx_i2s_disable(info, SNDRV_PCM_STREAM_PLAYBACK);
> ep93xx_i2s_disable(info, SNDRV_PCM_STREAM_CAPTURE);
> +
> + return 0;
> }
>
> static int ep93xx_i2s_resume(struct snd_soc_dai *dai)
> @@ -324,10 +326,12 @@ static int ep93xx_i2s_resume(struct snd_soc_dai *dai)
> struct ep93xx_i2s_info *info = snd_soc_dai_get_drvdata(dai);
>
> if (!dai->active)
> - return;
> + return 0;
>
> ep93xx_i2s_enable(info, SNDRV_PCM_STREAM_PLAYBACK);
> ep93xx_i2s_enable(info, SNDRV_PCM_STREAM_CAPTURE);
> +
> + return 0;
> }
> #else
> #define ep93xx_i2s_suspend NULL
>
>
--
Bluewater Systems Ltd - ARM Technology Solution Centre
Ryan Mallon 5 Amuri Park, 404 Barbadoes St
ryan@bluewatersys.com PO Box 13 889, Christchurch 8013
http://www.bluewatersys.com New Zealand
Phone: +64 3 3779127 Freecall: Australia 1800 148 751
Fax: +64 3 3779135 USA 1800 261 2934
next prev parent reply other threads:[~2011-03-06 22:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-05 0:57 [PATCH] ASoC: Remove warnings in ep93xx-i2s.c Alexander Sverdlin
2011-03-06 22:05 ` Ryan Mallon [this message]
2011-03-07 10:49 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D74053F.4010003@bluewatersys.com \
--to=ryan@bluewatersys.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@slimlogic.co.uk \
--cc=subaparts@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.