[Qemu-devel] Re: [PATCH 4/4] i8254: convert to qdev

[Anthony Liguori <anthony@codemonkey.ws>]

On 03/06/2011 03:18 PM, Jan Kiszka wrote:
>> It's far from academic as this is user-visible and visible via the
>> command line.
>>      
> I thought it was stated before that there is no guarantee on the
> internal structure of our device tree as the user may explore it (as
> long as it's stable for the guest).

We have a lot of "unstable" interfaces that folks yell about every time 
it changes (like the -help output).  Providing a bad external interface 
and justifying by saying its unstable is just asking for pain later.

>   Regarding command line: What are
> your worries here? The user can't mess with built-in devices.
>    

-global still applies to no_user devices.

> I still think we have more important things to improve than these
> cosmetic issues.
>    

What does converting this device to qdev actually add other than an 
interface that we're not going to be able to support long term?

Regards,

Anthony Liguori

> Jan
>
>