Re: [PATCH 1/2] dropbear: add 0.53.1

[Eric Benard <eric@eukrea.com>]

Hi Phil,

On 07/03/2011 10:57, Phil Blundell wrote:
> On Mon, 2011-03-07 at 10:50 +0100, Eric Benard wrote:
>> Hi Khem,
>>
>> On 06/03/2011 00:08, Khem Raj wrote:
>>> On Sat, Mar 5, 2011 at 1:30 PM, Eric Bénard<eric@eukrea.com>   wrote:
>>>> * 0.53.1 brings some improvements over 0.52 which was released
>>>> more than 2 years ago. For more details, check the changelog here :
>>>> http://matt.ucc.asn.au/dropbear/CHANGES
>>>> * Please note that DROPBEAR_SMALL_CODEis now disabled which may
>>>> increase the size of the binaries.
>>>
>>> can you compare the sizes of .52 and .53.1 so we know how much it will be
>>>>
>> for an armv5 target :
>> 0.53.1 : 228112
>> 0.53.1 + DROPBEAR_SMALL_CODE : 178960
>> 0.52 : 183008
>
> Looks like DROPBEAR_SMALL_CODE is still worth having then.  Why was it
> disabled?
>
the changelog doesn't say it but the comment in option.h says :
/* Set this if you want to use the DROPBEAR_SMALL_CODE option. This can save
several kB in binary size, however will make the symmetrical ciphers (AES, DES
etc) slower (perhaps by 50%). Recommended for most small systems. */

so maybe they prefered to get performance by default instead of saving 50kB.

We can keep this option by adding this to the recipe :
+do_configure_prepend() {
+       echo "#define DROPBEAR_SMALL_CODE" >>${S}/options.h
+}
+

Eric