From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Mon, 07 Mar 2011 13:24:28 +0100 (CET) Received: from nbd.name ([46.4.11.11]:34172 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S1491862Ab1CGMYZ (ORCPT ); Mon, 7 Mar 2011 13:24:25 +0100 Message-ID: <4D74CEC2.4040506@openwrt.org> Date: Mon, 07 Mar 2011 13:25:38 +0100 From: John Crispin User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.12) Gecko/20100913 Icedove/3.0.7 MIME-Version: 1.0 To: dedekind1@gmail.com CC: Ralf Baechle , linux-mips@linux-mips.org, Ralph Hempel , linux-mtd@lists.infradead.org, Daniel Schwierzeck , David Woodhouse Subject: Re: [PATCH V2 06/10] MIPS: lantiq: add NOR flash support References: <1298996006-15960-1-git-send-email-blogic@openwrt.org> <1298996006-15960-7-git-send-email-blogic@openwrt.org> <1299488320.2746.5.camel@localhost> In-Reply-To: <1299488320.2746.5.camel@localhost> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 29372 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: blogic@openwrt.org Precedence: bulk X-list: linux-mips On 07/03/11 09:58, Artem Bityutskiy wrote: > On Tue, 2011-03-01 at 17:13 +0100, John Crispin wrote: > >> NOR flash is attached to the same EBU (External Bus Unit) as PCI. As described >> in the PCI patch, the EBU is a little buggy, resulting in the upper and lower >> 16 bit of the data on a 32 bit read are swapped. (essentially we have a addr^=2) >> >> To work around this we do a addr^=2 during the probe. Once probed we adapt >> cfi->addr_unlock1 and cfi->addr_unlock2 to represent the endianess bug. >> >> Changes in V2 >> * handle the endianess bug inside the map code and not in the generic cfi code >> * remove the addr swizzle patch >> >> Signed-off-by: John Crispin >> Signed-off-by: Ralph Hempel >> Cc: David Woodhouse >> Cc: Daniel Schwierzeck >> Cc: linux-mips@linux-mips.org >> Cc: linux-mtd@lists.infradead.org >> > There are a couple checkpatch.pl warnings, would you please address them > and resend? > > Hi, of course. thanks, John From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from nbd.name ([46.4.11.11]) by canuck.infradead.org with esmtps (Exim 4.72 #1 (Red Hat Linux)) id 1PwZUG-00019H-Av for linux-mtd@lists.infradead.org; Mon, 07 Mar 2011 12:24:33 +0000 Message-ID: <4D74CEC2.4040506@openwrt.org> Date: Mon, 07 Mar 2011 13:25:38 +0100 From: John Crispin MIME-Version: 1.0 To: dedekind1@gmail.com Subject: Re: [PATCH V2 06/10] MIPS: lantiq: add NOR flash support References: <1298996006-15960-1-git-send-email-blogic@openwrt.org> <1298996006-15960-7-git-send-email-blogic@openwrt.org> <1299488320.2746.5.camel@localhost> In-Reply-To: <1299488320.2746.5.camel@localhost> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: linux-mips@linux-mips.org, Ralf Baechle , Ralph Hempel , linux-mtd@lists.infradead.org, Daniel Schwierzeck , David Woodhouse List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 07/03/11 09:58, Artem Bityutskiy wrote: > On Tue, 2011-03-01 at 17:13 +0100, John Crispin wrote: > >> NOR flash is attached to the same EBU (External Bus Unit) as PCI. As described >> in the PCI patch, the EBU is a little buggy, resulting in the upper and lower >> 16 bit of the data on a 32 bit read are swapped. (essentially we have a addr^=2) >> >> To work around this we do a addr^=2 during the probe. Once probed we adapt >> cfi->addr_unlock1 and cfi->addr_unlock2 to represent the endianess bug. >> >> Changes in V2 >> * handle the endianess bug inside the map code and not in the generic cfi code >> * remove the addr swizzle patch >> >> Signed-off-by: John Crispin >> Signed-off-by: Ralph Hempel >> Cc: David Woodhouse >> Cc: Daniel Schwierzeck >> Cc: linux-mips@linux-mips.org >> Cc: linux-mtd@lists.infradead.org >> > There are a couple checkpatch.pl warnings, would you please address them > and resend? > > Hi, of course. thanks, John