All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Jones <michael.jones@matrix-vision.de>
To: David Cohen <dacohen@gmail.com>
Cc: Hiroshi.DOYU@nokia.com,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	fernando.lugo@ti.com,
	Sakari Ailus <sakari.ailus@maxwell.research.nokia.com>,
	Linux Media Mailing List <linux-media@vger.kernel.org>,
	linux-omap@vger.kernel.org
Subject: [PATCH] omap: iommu: disallow mapping NULL address
Date: Mon, 07 Mar 2011 14:10:39 +0100	[thread overview]
Message-ID: <4D74D94F.7040702@matrix-vision.de> (raw)
In-Reply-To: <AANLkTi=8Sss-5xfgPmgx=J_T__=hrC1rQU-xBOdKC8Ve@mail.gmail.com>

>From e7dbe4c4b64eb114f9b0804d6af3a3ca0e78acc8 Mon Sep 17 00:00:00 2001
From: Michael Jones <michael.jones@matrix-vision.de>
Date: Mon, 7 Mar 2011 13:36:15 +0100
Subject: [PATCH] omap: iommu: disallow mapping NULL address

commit c7f4ab26e3bcdaeb3e19ec658e3ad9092f1a6ceb allowed mapping
the NULL address if da_start==0.  Force da_start to exclude the
first page.

Signed-off-by: Michael Jones <michael.jones@matrix-vision.de>
---
 arch/arm/plat-omap/iommu.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/arm/plat-omap/iommu.c b/arch/arm/plat-omap/iommu.c
index 5990ea6..dcb5513 100644
--- a/arch/arm/plat-omap/iommu.c
+++ b/arch/arm/plat-omap/iommu.c
@@ -850,7 +850,7 @@ int iommu_set_da_range(struct iommu *obj, u32 start, u32 end)
 	if (end < start || !PAGE_ALIGN(start | end))
 		return -EINVAL;
 
-	obj->da_start = start;
+	obj->da_start = max(start, (u32)PAGE_SIZE);
 	obj->da_end = end;
 
 	return 0;
@@ -950,7 +950,9 @@ static int __devinit omap_iommu_probe(struct platform_device *pdev)
 	obj->name = pdata->name;
 	obj->dev = &pdev->dev;
 	obj->ctx = (void *)obj + sizeof(*obj);
-	obj->da_start = pdata->da_start;
+
+	/* reserve the first page for NULL */
+	obj->da_start = max(pdata->da_start, (u32)PAGE_SIZE);
 	obj->da_end = pdata->da_end;
 
 	mutex_init(&obj->iommu_lock);
-- 
1.7.4.1


MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler
Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner

  reply	other threads:[~2011-03-07 13:10 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-01 16:41 omap3isp cache error when unloading Michael Jones
2011-03-02 19:18 ` Laurent Pinchart
2011-03-03 16:06   ` Michael Jones
2011-03-04  7:38     ` Sakari Ailus
2011-03-04 10:07       ` Hiroshi DOYU
2011-03-04 13:12     ` David Cohen
2011-03-04 13:12       ` David Cohen
2011-03-04 14:39       ` Michael Jones
2011-03-04 15:45         ` David Cohen
2011-03-04 16:49           ` David Cohen
2011-03-07 13:10             ` Michael Jones [this message]
2011-03-07 19:17               ` [PATCH] omap: iommu: disallow mapping NULL address Guzman Lugo, Fernando
2011-03-07 19:17                 ` Guzman Lugo, Fernando
2011-03-07 19:19                 ` David Cohen
2011-03-07 19:25                   ` Guzman Lugo, Fernando
2011-03-07 19:41                     ` David Cohen
2011-03-07 19:41                       ` David Cohen
2011-03-07 21:19                       ` Laurent Pinchart
2011-03-07 21:35                         ` David Cohen
2011-03-07 21:35                           ` David Cohen
2011-03-08  9:07                           ` Hiroshi DOYU
2011-03-08  9:07                             ` Hiroshi DOYU
2011-03-08 20:31                           ` Laurent Pinchart
2011-03-08 20:41                             ` Guzman Lugo, Fernando
2011-03-08 20:41                               ` Guzman Lugo, Fernando
2011-03-08 20:51                             ` David Cohen
2011-03-09  7:55                               ` Sakari Ailus
2011-03-08  9:02                       ` Hiroshi DOYU
2011-03-08  9:13                     ` Sakari Ailus
2011-03-08  9:55                       ` David Cohen
2011-03-08  9:55                         ` David Cohen
2011-03-08 17:49                         ` Guzman Lugo, Fernando
2011-03-08 17:49                           ` Guzman Lugo, Fernando
2011-03-08 17:45                       ` Guzman Lugo, Fernando

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D74D94F.7040702@matrix-vision.de \
    --to=michael.jones@matrix-vision.de \
    --cc=Hiroshi.DOYU@nokia.com \
    --cc=dacohen@gmail.com \
    --cc=fernando.lugo@ti.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=sakari.ailus@maxwell.research.nokia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.