From mboxrd@z Thu Jan  1 00:00:00 1970
Message-ID: <4D74EFB0.7000807@domain.hid>
Date: Mon, 07 Mar 2011 15:46:08 +0100
From: Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
MIME-Version: 1.0
References: <4D74EE69.5020705@domain.hid>
In-Reply-To: <4D74EE69.5020705@domain.hid>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Xenomai-help] Build and run xenomai 2.5.5.2 - linux-2.6.33 on
 imx27
List-Id: Help regarding installation and common use of Xenomai
	<xenomai.xenomai.org>
List-Unsubscribe: <https://mail.gna.org/options/xenomai-help>,
	<mailto:xenomai-help-request@domain.hid>
List-Archive: </public/xenomai-help>
List-Post: <mailto:xenomai@xenomai.org>
List-Help: <mailto:xenomai-help-request@domain.hid>
List-Subscribe: <https://mail.gna.org/listinfo/xenomai-help>,
	<mailto:xenomai-help-request@domain.hid>
To: Fabrice Gasnier <fabrice.gasnier@domain.hid>
Cc: xenomai@xenomai.org

Fabrice Gasnier wrote:
> Dear all,
>=20
> I'm currently evaluating xenomai 2.5.5.2 on a i.MX27 platform with=20
> adeos-ipipe-2.6.33-arm-1.18-01.patch.
>=20
>=20
> I've encountred two issues for the time being  (same with=20
> adeos-ipipe-2.6.33-arm-1.18-00.patch).
>=20
> 1=C2=B0/ First one happens when building a 2.6.33.3 kernel (after xenom=
ai=20
> prepare/configure/compile stage):
>=20
> CC      arch/arm/plat-mxc/time.o
> arch/arm/plat-mxc/time.c: In function 'mxc_timer_init':
> arch/arm/plat-mxc/time.c:400: error: 'TIM1_BASE_ADDR' undeclared (first=
=20
> use in this function)
> arch/arm/plat-mxc/time.c:400: error: (Each undeclared identifier is=20
> reported only once
> arch/arm/plat-mxc/time.c:400: error: for each function it appears in.)
> make[1]: *** [arch/arm/plat-mxc/time.o] Erreur 1
> make: *** [arch/arm/plat-mxc] Erreur 2
>=20
>=20
> I first tried 2.6.31 kernel that was compiling (patched with=20
> adeos-ipipe-2.6.31-arm-1.16-02.patch).
> Looking for differences lead me to patch my kernel with:
>=20
> Index: linux-2.6.33.3/arch/arm/plat-mxc/time.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- linux-2.6.33.3.orig/arch/arm/plat-mxc/time.c    2011-02-28=20
> 11:44:02.000000000 +0100
> +++ linux-2.6.33.3/arch/arm/plat-mxc/time.c    2011-02-28=20
> 11:48:19.000000000 +0100
> @@ -395,12 +395,17 @@
>       tsc_info.freq =3D clk_get_rate(timer_clk);
>       mxc_min_delay =3D ((__ipipe_cpu_freq + 500000) / 1000000) ?: 1;
>=20
> -    if (cpu_is_mx1() || cpu_is_mx2()) {
> -#if defined(CONFIG_ARCH_MX1) || defined(CONFIG_ARCH_MX2)
> +    if (cpu_is_mx1()) {
> +#ifdef CONFIG_ARCH_MX1
>           tsc_info.u.counter_paddr =3D (TIM1_BASE_ADDR + MX1_2_TCN);
>           tsc_info.counter_vaddr =3D
>               (unsigned long)(timer_base + MX1_2_TCN);
>   #endif
> +    } else if (cpu_is_mx2()) {
> +#ifdef CONFIG_ARCH_MX2
> +        tsc_info.u.counter_paddr =3D (GPT1_BASE_ADDR + MX1_2_TCN);
> +        tsc_info.counter_vaddr =3D (unsigned long)(timer_base + MX1_2_=
TCN);
> +#endif
>       } else if (cpu_is_mx3()) {
>   #ifdef CONFIG_ARCH_MX3
>           tsc_info.u.counter_paddr =3D (GPT1_BASE_ADDR + MX3_TCN);

Ok. I'll take this one.

>   #ifdef CONFIG_IPIPE
>   void ipipe_mach_allow_hwtimer_uaccess(unsigned long aips1, unsigned=20
> long aips2);
> +#if defined(CONFIG_ARCH_MX1) || defined(CONFIG_ARCH_MX2)
> +void ipipe_mach_allow_uaccess(unsigned long aipi_base_addr, unsigned=20
> long bit_num);
> +#endif
>   #endif

Look the function above, you are adding a function which is already
there, please reuse the same function, instead of duplicating it...

--=20
					    Gilles.