Re: [PATCH] ahci: EM supported message type sysfs attribute

[Hannes Reinecke <hare@suse.de>]

On 03/04/2011 07:39 PM, Kristen Carlson Accardi wrote:
> On Fri, 04 Mar 2011 09:54:52 +0100
> hare@suse.de (Hannes Reinecke) wrote:
> 
>>
>> This patch adds an sysfs attribute 'em_message_supported' to the
>> ahci host device which prints out the supported enclosure management
>> message types.
> 
> Is it useful to display the host controllers supported em
> message types when libata only can support LED type?

Yes. libata might only support LED types currently.
However, as other types are defined as per spec
we'll be coming across those types eventually.

But with the current code we don't have any means of detecting them.
libata just prints out 'ems' at module load time, without any hint
which message type is actually supported.

With this patch we can now signal the presence of additional message
types to the user, allowing him to start hacking :-)

Incidentally, if you know of a chipset/board already supporting
different message types I'm all ears :-)

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)