From: Dominic Curran <dominic.curran@citrix.com>
To: xen-devel@lists.xensource.com
Subject: blktap: fix reference to freed struct request.
Date: Tue, 8 Mar 2011 18:18:31 +0000 [thread overview]
Message-ID: <4D7672F7.1040805@citrix.com> (raw)
blktap: fix reference to freed struct request.
The request will be freed by the call to __blktap_end_rq(), so to
rq->q is invalid before spin_unlock_irq().
Signed-off-by: Dominic Curran <dominic.curran@
Acked-by: Daniel Stodden <daniel.stodden@citrix.com>
diff -r d971c4c2e309 drivers/xen/blktap2/device.c
--- a/drivers/xen/blktap2/device.c Tue Mar 08 10:02:58 2011 -0800
+++ b/drivers/xen/blktap2/device.c Tue Mar 08 10:04:28 2011 -0800
@@ -135,9 +135,11 @@
static inline void
blktap_end_rq(struct request *rq, int err)
{
- spin_lock_irq(rq->q->queue_lock);
+ struct request_queue *q = rq->q;
+
+ spin_lock_irq(q->queue_lock);
__blktap_end_rq(rq, err);
- spin_unlock_irq(rq->q->queue_lock);
+ spin_unlock_irq(q->queue_lock);
}
void
next reply other threads:[~2011-03-08 18:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-08 18:18 Dominic Curran [this message]
2011-03-08 18:44 ` blktap: fix reference to freed struct request Daniel Stodden
2011-03-08 18:57 ` Keir Fraser
2011-03-08 19:09 ` Daniel Stodden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D7672F7.1040805@citrix.com \
--to=dominic.curran@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.