From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=34055 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PxFf0-0000Aa-J6 for qemu-devel@nongnu.org; Wed, 09 Mar 2011 04:26:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PxFez-0001wm-H1 for qemu-devel@nongnu.org; Wed, 09 Mar 2011 04:26:26 -0500 Received: from demumfd002.nsn-inter.net ([93.183.12.31]:12258) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PxFez-0001wD-8H for qemu-devel@nongnu.org; Wed, 09 Mar 2011 04:26:25 -0500 Message-ID: <4D77479D.9010903@nsn.com> Date: Wed, 09 Mar 2011 10:25:49 +0100 From: Bernhard Kohl MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH] lsi53c895a: add support for ABORT messages References: <1283784174-30436-1-git-send-email-bernhard.kohl@nsn.com> <4CADAE8E.2050405@redhat.com> <34941DDA-4ADD-478F-A529-2B48F4A64541@dlh.net> <4D773E9F.6060009@redhat.com> In-Reply-To: <4D773E9F.6060009@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: ext Kevin Wolf Cc: Peter Lieven , qemu-devel@nongnu.org, "Nicholas A. Bellinger" , Hannes Reinecke Am 09.03.2011 09:47, schrieb ext Kevin Wolf: > Am 09.03.2011 00:04, schrieb Peter Lieven: >> Am 07.10.2010 um 13:27 schrieb Kevin Wolf: >> >>> Am 06.09.2010 16:42, schrieb Bernhard Kohl: >>>> If these messages are not handled correctly the guest driver may hang. >>>> >>>> Always mandatory: >>>> - ABORT >>>> - BUS DEVICE RESET >>>> >>>> Mandatory if tagged queuing is implemented (which disks usually do): >>>> - ABORT TAG >>>> - CLEAR QUEUE >>>> >>>> Signed-off-by: Bernhard Kohl >>> Nicholas, as you seem to have touched the lsi code recently, care to >>> review this one? Assuming that you are reasonably familiar with both the >>> hardware and the code, you should be quicker than me with this. >> Is there a reason why this patch was never added to the stable qemu-kvm release? >> At least int qemu-kvm-0.14.0 I still can't find it. > The reason is that it still didn't get a review. > I still depend on this patch. It's needed for our legacy guest OS. It's heavily in use here with STGT iSCSI disks via scsi-generic. Bernhard