Re: [Qemu-devel] Re: [RFC][PATCH v7 01/16] Move code related to fd handlers into utility functions

[Anthony Liguori <anthony@codemonkey.ws>]

On 03/09/2011 07:58 AM, Paolo Bonzini wrote:
> On 03/07/2011 09:10 PM, Michael Roth wrote:
>> This allows us to implement an i/o loop outside of vl.c that can
>> interact with objects that use qemu_set_fd_handler()
>
> I must say I really dislike the patches 1..3.  It's _really_ getting 
> the QEMU NIH worse.  While it is not really possible to get a new 
> shiny mainloop infrastructure in QEMU like snapping fingers (and I'm 
> not sure the glib mainloop will ever happen there), there is no reason 
> not to adopt glib's infrastructure in virtagent.

I'm 90% in agreement with you but in terms of delivering a Windows guest 
agent, instead of just having an exe, we're now talking about quite a 
few extra DLLs.  It's not a huge problem and probably makes a ton of 
sense if virt-agent ever adopts more sophisticated functionality but I 
wanted to at least raise this point.

Regards,

Anthony Liguori

>   While cooperation between QEMU and virtagent is close, it is IMHO a 
> substantially separate project that can afford starting from a clean 
> slate.
>
> If anybody disagrees, I'd be happy to hear their opinion anyway!
>
> I'm sorry I'm saying this only now and I've been ignoring this series 
> until v7.
>
> Paolo
>
>