All of lore.kernel.org
 help / color / mirror / Atom feed
From: Carsten Emde <C.Emde@osadl.org>
To: Geunsik Lim <leemgs1@gmail.com>
Cc: williams@redhat.com, jkacur@redhat.com,
	linux-rt-users@vger.kernel.org, tglx@linutronix.de
Subject: Re: [PATCH RESEND v2] cyclictest: Fixed incorrect wakeup reset interface
Date: Wed, 09 Mar 2011 16:30:23 +0100	[thread overview]
Message-ID: <4D779D0F.8020003@osadl.org> (raw)
In-Reply-To: <1299683339-14381-1-git-send-email-leemgs1@gmail.com>

On 03/09/2011 04:08 PM, Geunsik Lim wrote:
> When we try to run ftrace with cyclictest command of rt-test,
> We view the error according to base kernel version.
> We need to modify this hard coded interface.
>
> Signed-off-by: Geunsik Lim<geunsik.lim@samsung.com>
We need a space here: Geunsik Lim <geunsik.lim@samsung.com>

> ---
>   src/cyclictest/cyclictest.c |    3 ++-
>   1 files changed, 2 insertions(+), 1 deletions(-)
Oops, this is still old, it's only 1 insertion now. You could have 
produced a real patch, couldn't you?

> diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
> index 0847aed..abc0b4e 100644
> --- a/src/cyclictest/cyclictest.c
> +++ b/src/cyclictest/cyclictest.c
> @@ -487,7 +487,7 @@ static void setup_tracer(void)
>   				setkernvar(traceroptions, traceptr[i]);
>   		}
>   		setkernvar("tracing_max_latency", "0");
> -		setkernvar("latency_hist/wakeup_latency/reset", "1");
> +		setkernvar("latency_hist/wakeup/reset", "1");
>   	} else {
>   		setkernvar("trace_all_cpus", "1");
>   		setkernvar("trace_freerunning", "1");
Acked-by: Carsten Emde <C.Emde@osadl.org>

  reply	other threads:[~2011-03-09 15:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-09 15:08 [PATCH RESEND v2] cyclictest: Fixed incorrect wakeup reset interface Geunsik Lim
2011-03-09 15:30 ` Carsten Emde [this message]
2011-03-09 20:26   ` John Kacur
2011-03-09 23:32     ` Geunsik Lim
2011-03-09 20:27   ` John Kacur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D779D0F.8020003@osadl.org \
    --to=c.emde@osadl.org \
    --cc=jkacur@redhat.com \
    --cc=leemgs1@gmail.com \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=williams@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.