From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] gatchat: fix to number parsing when number is omitted
Date: Wed, 09 Mar 2011 16:03:40 -0600 [thread overview]
Message-ID: <4D77F93C.7020206@gmail.com> (raw)
In-Reply-To: <1299655650-7929-1-git-send-email-paavo.leinonen@tieto.com>
[-- Attachment #1: Type: text/plain, Size: 760 bytes --]
Hi Paavo,
On 03/09/2011 01:27 AM, Paavo Leinonen wrote:
> Line position index must be updated the number field is empty. Otherwise
> we will read same field again in subsequent calls.
> ---
>
> Hi,
>
> While testing SIM Phonebook we noticed that Email addresses stored to SIM PB
> were not properly parsed by oFono. Root cause for this was
> g_at_result_iter_next_number which did not update iterator's line_pos
> attribute when number was missing. As a result, wrong fields were
> read when parsing email field (among others).
This is actually on purpose, we do not want to consume the field if the
parsing failed. For fields that might have omitted entries I suggest
you use g_at_result_iter_next_number_default.
Regards,
-Denis
next prev parent reply other threads:[~2011-03-09 22:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-09 7:27 [PATCH] gatchat: fix to number parsing when number is omitted Paavo Leinonen
2011-03-09 22:03 ` Denis Kenzior [this message]
2011-03-11 12:25 ` [PATCH] atmodem: fix PB reading when fields are omitted Paavo Leinonen
2011-03-11 19:56 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D77F93C.7020206@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.