From: Zachary Amsden <zamsden@redhat.com>
To: Nikola Ciprich <extmaillist@linuxbox.cz>
Cc: KVM list <kvm@vger.kernel.org>,
Linux kernel list <linux-kernel@vger.kernel.org>,
nikola.ciprich@linuxbox.cz, Avi Kivity <avi@redhat.com>,
Glauber Costa <glommer@redhat.com>
Subject: Re: [PATCHv2] fix regression caused by e48672fa25e879f7ae21785c7efd187738139593
Date: Thu, 10 Mar 2011 02:01:27 -0500 [thread overview]
Message-ID: <4D787747.7080207@redhat.com> (raw)
In-Reply-To: <20110309223651.GC1762@pcnci.linuxbox.cz>
On 03/09/2011 05:36 PM, Nikola Ciprich wrote:
> commit 387b9f97750444728962b236987fbe8ee8cc4f8c moved kvm_request_guest_time_update(vcpu),
> breaking 32bit SMP guests using kvm-clock. Fix this by moving (new) clock update function
> to proper place.
>
> Signed-off-by: Nikola Ciprich<nikola.ciprich@linuxbox.cz>
> ---
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 4c27144..ba3f76f 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -2101,8 +2101,8 @@ void kvm_arch_vcpu_load(struct kvm_vcpu *vcpu, int cpu)
> if (check_tsc_unstable()) {
> kvm_x86_ops->adjust_tsc_offset(vcpu, -tsc_delta);
> vcpu->arch.tsc_catchup = 1;
> - kvm_make_request(KVM_REQ_CLOCK_UPDATE, vcpu);
> }
> + kvm_make_request(KVM_REQ_CLOCK_UPDATE, vcpu);
> if (vcpu->cpu != cpu)
> kvm_migrate_timers(vcpu);
> vcpu->cpu = cpu;
>
>
ACK
next prev parent reply other threads:[~2011-03-10 7:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-07 10:18 [PATCH] add missing guest clock update removed by e48672fa25e879f7ae21785c7efd187738139593 Nikola Ciprich
2011-03-08 19:58 ` Zachary Amsden
2011-03-09 19:30 ` Nikola Ciprich
2011-03-09 21:29 ` Zachary Amsden
2011-03-09 22:36 ` [PATCHv2] fix regression caused " Nikola Ciprich
2011-03-10 7:01 ` Zachary Amsden [this message]
2011-03-10 9:07 ` Avi Kivity
2011-03-25 8:20 ` Zachary Amsden
2011-03-26 14:47 ` Nikola Ciprich
2011-04-11 16:12 ` Nikola Ciprich
2011-04-12 15:36 ` Zachary Amsden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D787747.7080207@redhat.com \
--to=zamsden@redhat.com \
--cc=avi@redhat.com \
--cc=extmaillist@linuxbox.cz \
--cc=glommer@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikola.ciprich@linuxbox.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.