Re: [PATCH 0/2] OMAP3: wdtimer: fix wdtimer blocking CORE idle

["Cousson, Benoit" <b-cousson@ti.com>]

Paul,

On 3/10/2011 11:28 AM, kalle.jokiniemi@nokia.com wrote:
>
>
>> -----Original Message-----
>> From: ext Paul Walmsley [mailto:paul@pwsan.com]
>> Sent: 10. maaliskuuta 2011 11:50
>> To: Jokiniemi Kalle (Nokia-MS/Tampere)
>> Cc: khilman@ti.com; linux-omap@vger.kernel.org; Koskinen Ilkka (Nokia-
>> MS/Tampere); jhnikula@gmail.com; b-cousson@ti.com
>> Subject: Re: [PATCH 0/2] OMAP3: wdtimer: fix wdtimer blocking CORE idle
>>
>>
>> Thanks Kalle for tracking this down,
>>
>> could you try this patch along with the patch from this message:
>>
>>    http://www.spinics.net/lists/linux-omap/msg48115.html

I have some question with that patch.
By using pm_runtime API, you are suppose to idle the whole IP.
In this case, just because you cannot idle a wdt that is running, it 
works, but the point is that the pm_runtime state will not reflect the 
HW state.
For pm_runtime point of view, the wdt is supposed to be fully idle (both 
fclk and iclk). Whereas in that case, only the iclk will be gated.

Did I miss something?

Benoit


>> and see if it also fixes the problem?
>
> It works as well it seems :)
>
> I assume you prefer this fix to be applied, so I'll send patches on this.
>
> - Kalle
>
>
>>
>> This patch should also prevent the hwmod code from putting the WDT2 into
>> smart-idle mode.
>>
>>
>> - Paul
>>
>>
>> ---
>>   arch/arm/mach-omap2/omap_hwmod_3xxx_data.c |    1 +
>>   1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
>> b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
>> index 457df3e..4366b85 100644
>> --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
>> +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
>> @@ -1294,6 +1294,7 @@ static struct omap_hwmod
>> omap3xxx_wd_timer2_hwmod = {
>>   	.slaves		= omap3xxx_wd_timer2_slaves,
>>   	.slaves_cnt	= ARRAY_SIZE(omap3xxx_wd_timer2_slaves),
>>   	.omap_chip	= OMAP_CHIP_INIT(CHIP_IS_OMAP3430),
>> +	.flags		= HWMOD_SWSUP_SIDLE,
>>   };
>>
>>   /* UART common */
>> --
>> 1.7.2.3
>