From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH 2/2] vnc: don't mess up with iohandlers in the vnc thread Date: Thu, 10 Mar 2011 07:45:39 -0600 Message-ID: <4D78D603.5060000@us.ibm.com> References: <4D7767C0.6060609@siemens.com> <1299761979-15197-2-git-send-email-corentin.chary@gmail.com> <4D78CCDF.6090906@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Corentin Chary , Jan Kiszka , Peter Lieven , qemu-devel , kvm@vger.kernel.org, Anthony Liguori To: Paolo Bonzini Return-path: Received: from e9.ny.us.ibm.com ([32.97.182.139]:60196 "EHLO e9.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752683Ab1CJNpz (ORCPT ); Thu, 10 Mar 2011 08:45:55 -0500 Received: from d01dlp01.pok.ibm.com (d01dlp01.pok.ibm.com [9.56.224.56]) by e9.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p2ADJJ0Z014512 for ; Thu, 10 Mar 2011 08:19:19 -0500 Received: from d01relay07.pok.ibm.com (d01relay07.pok.ibm.com [9.56.227.147]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 1135A38C8038 for ; Thu, 10 Mar 2011 08:45:42 -0500 (EST) Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by d01relay07.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p2ADjg4K2015236 for ; Thu, 10 Mar 2011 08:45:42 -0500 Received: from d01av03.pok.ibm.com (loopback [127.0.0.1]) by d01av03.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p2ADjeLa017884 for ; Thu, 10 Mar 2011 10:45:42 -0300 In-Reply-To: <4D78CCDF.6090906@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 03/10/2011 07:06 AM, Paolo Bonzini wrote: > On 03/10/2011 01:59 PM, Corentin Chary wrote: >> Instead, we now store the data in a temporary buffer, and use a socket >> pair to notify the main thread that new data is available. > > You can use a bottom half for this instead of a special socket. > Signaling a bottom half is async-signal- and thread-safe. Bottom halves are thread safe? I don't think so. They probably should be but they aren't today. Regards, Anthony Liguori > > Paolo From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=38735 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PxgBl-0003Ti-3J for qemu-devel@nongnu.org; Thu, 10 Mar 2011 08:46:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PxgBk-00018V-9q for qemu-devel@nongnu.org; Thu, 10 Mar 2011 08:46:01 -0500 Received: from e2.ny.us.ibm.com ([32.97.182.142]:49624) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PxgBk-00018O-7e for qemu-devel@nongnu.org; Thu, 10 Mar 2011 08:46:00 -0500 Received: from d01dlp02.pok.ibm.com (d01dlp02.pok.ibm.com [9.56.224.85]) by e2.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p2ADRHLE004316 for ; Thu, 10 Mar 2011 08:27:17 -0500 Received: from d01relay03.pok.ibm.com (d01relay03.pok.ibm.com [9.56.227.235]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 1D5E96E8036 for ; Thu, 10 Mar 2011 08:45:42 -0500 (EST) Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by d01relay03.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p2ADjfwY271008 for ; Thu, 10 Mar 2011 08:45:41 -0500 Received: from d01av03.pok.ibm.com (loopback [127.0.0.1]) by d01av03.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p2ADjeLU017884 for ; Thu, 10 Mar 2011 10:45:41 -0300 Message-ID: <4D78D603.5060000@us.ibm.com> Date: Thu, 10 Mar 2011 07:45:39 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <4D7767C0.6060609@siemens.com> <1299761979-15197-2-git-send-email-corentin.chary@gmail.com> <4D78CCDF.6090906@redhat.com> In-Reply-To: <4D78CCDF.6090906@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 2/2] vnc: don't mess up with iohandlers in the vnc thread List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kvm@vger.kernel.org, Jan Kiszka , qemu-devel , Anthony Liguori , Corentin Chary , Peter Lieven On 03/10/2011 07:06 AM, Paolo Bonzini wrote: > On 03/10/2011 01:59 PM, Corentin Chary wrote: >> Instead, we now store the data in a temporary buffer, and use a socket >> pair to notify the main thread that new data is available. > > You can use a bottom half for this instead of a special socket. > Signaling a bottom half is async-signal- and thread-safe. Bottom halves are thread safe? I don't think so. They probably should be but they aren't today. Regards, Anthony Liguori > > Paolo