All of lore.kernel.org
 help / color / mirror / Atom feed
From: Harald Kipp <harald.kipp@egnite.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] AT91 timer patch broke DataFlash driver
Date: Thu, 10 Mar 2011 14:54:00 +0100	[thread overview]
Message-ID: <4D78D7F8.8080502@egnite.de> (raw)

Hi,

Commit 5dca710a3d7703e41da0e9894f2d71f9e25bea6b
http://lists.denx.de/pipermail/u-boot/2010-October/078600.html
removed the two global routines reset_timer_masked() and 
get_timer_masked() from arch/arm/cpu/arm926ejs/at91/timer.c.

Both routines are still referenced in drivers/spi/atmel_dataflash_spi.c. 
As a result SPI DataFlash support fails to compile for AT91 boards.

This had been also reported by
http://lists.denx.de/pipermail/u-boot/2011-January/085399.html
http://lists.denx.de/pipermail/u-boot/2010-November/081287.html
but the problem still exists in the master trunk and the at91 branch.

For a first test I simply added

void reset_timer_masked(void)
{
	reset_timer();
}

ulong get_timer_masked(void)
{
	return tick_to_time(get_ticks() - gd->timer_reset_value);
}

to drivers/spi/atmel_dataflash_spi.c. All DataFlash functions seem to 
work with this. But I'm not sure if this is a proper replacement for the 
original code.

Regards,

Harald

             reply	other threads:[~2011-03-10 13:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-10 13:54 Harald Kipp [this message]
2011-03-10 18:31 ` [U-Boot] AT91 timer patch broke DataFlash driver Harald Kipp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D78D7F8.8080502@egnite.de \
    --to=harald.kipp@egnite.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.