All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Heffner <mike@librato.com>
To: Paul Menage <menage@google.com>
Cc: Eric B Munson <emunson@mgebm.net>,
	linux-kernel@vger.kernel.org,
	containers@lists.linux-foundation.org, rdunlap@xenotime.net,
	linux-doc@vger.kernel.org
Subject: Re: [PATCH] Documentation: cgroups: Add notes on removing PIDs from tasks and cgroups requiring setup
Date: Thu, 10 Mar 2011 09:44:59 -0500	[thread overview]
Message-ID: <4D78E3EB.8080207@librato.com> (raw)
In-Reply-To: <AANLkTinW99M1FBp5gRA=+SsjUWSJBwByurqrsjXKgQ4=@mail.gmail.com>

On 03/09/2011 06:13 PM, Paul Menage wrote:
> On Wed, Mar 9, 2011 at 1:09 PM, Eric B Munson<emunson@mgebm.net>  wrote:
>>
>> +Note: To remove a task from a cgroup you must write its PID to the root
>> +tasks file.
>> +
>
> This isn't really accurate - the root cgroup is a cgroup like all the
> others. More accurate would be something like:
>
> Since every task is always a member of exactly one cgroup in each
> mounted hierarchy, to remove a task from its current cgroup you must
> move it into a new cgroup (possibly the root cgroup) by writing to the
> new cgroup's tasks file.


If we are updating this documentation, can we include a blurb that 
mentions if the 'ns' cgroup is mounted in the hierarchy, moving a 
process to a new cgroup can fail?


Mike


  reply	other threads:[~2011-03-10 14:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-09 21:09 [PATCH] Documentation: cgroups: Add notes on removing PIDs from tasks and cgroups requiring setup Eric B Munson
2011-03-09 23:07 ` Kirill A. Shutemov
     [not found] ` <1299704969-4485-1-git-send-email-emunson-CVBTeua0HjReoWH0uzbU5w@public.gmane.org>
2011-03-09 23:07   ` Kirill A. Shutemov
2011-03-09 23:13   ` Paul Menage
2011-03-09 23:13 ` Paul Menage
2011-03-10 14:44   ` Mike Heffner [this message]
2011-03-10 14:44   ` Mike Heffner
2011-03-10 16:59   ` Eric B Munson
2011-03-10 16:59   ` Eric B Munson
  -- strict thread matches above, loose matches on Subject: below --
2011-03-09 21:09 Eric B Munson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D78E3EB.8080207@librato.com \
    --to=mike@librato.com \
    --cc=containers@lists.linux-foundation.org \
    --cc=emunson@mgebm.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=menage@google.com \
    --cc=rdunlap@xenotime.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.