From: Bob Breuer <breuerr@mc.net>
To: sparclinux@vger.kernel.org
Subject: Re: sparc32 build failure in fault_32.c
Date: Thu, 10 Mar 2011 17:49:29 +0000 [thread overview]
Message-ID: <4D790F29.6040109@mc.net> (raw)
In-Reply-To: <4D7410E5.3090904@mc.net>
David Miller wrote:
> From: Bob Breuer <breuerr@mc.net>
> Date: Sun, 06 Mar 2011 16:55:33 -0600
>
>> Would it be safe enough to initialize code to SEGV_MAPERR earlier, or
>> should vmalloc_fault have a different fault code?
>
> Yep, and that's how I'll fix this, thanks!
>
> ---
> sparc32: Fix might-be-used-uninitialized warning in do_sparc_fault().
>
> When we try to handle vmalloc faults, we can take a code
> path which uses "code" before we actually set it.
>
> Amusingly gcc-3.3 notices this yet gcc-4.x does not.
>
> Reported-by: Bob Breuer <breuerr@mc.net>
> Signed-off-by: David S. Miller <davem@davemloft.net>
> ---
Thanks, no errors during compile.
Tested-by: Bob Breuer <breuerr@mc.net>
prev parent reply other threads:[~2011-03-10 17:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-06 22:55 sparc32 build failure in fault_32.c Bob Breuer
2011-03-09 21:01 ` David Miller
2011-03-10 17:49 ` Bob Breuer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D790F29.6040109@mc.net \
--to=breuerr@mc.net \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.