From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] z2-battery: Fix count of properties
Date: Fri, 11 Mar 2011 15:11:45 +0300 [thread overview]
Message-ID: <4D7A1181.2000802@ru.mvista.com> (raw)
In-Reply-To: <1299837813-14952-1-git-send-email-anarsoul@gmail.com>
Hello.
On 11-03-2011 13:03, Vasily Khoruzhick wrote:
> PROP_STATUS property was not counted, as result
> VOLTAGE_MIN property is missing in sysfs. Fix it.
> Signed-off-by: Vasily Khoruzhick<anarsoul@gmail.com>
> ---
> drivers/power/z2_battery.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
> diff --git a/drivers/power/z2_battery.c b/drivers/power/z2_battery.c
> index e5ed52d..551d7bf 100644
> --- a/drivers/power/z2_battery.c
> +++ b/drivers/power/z2_battery.c
> @@ -134,6 +134,8 @@ static int z2_batt_ps_init(struct z2_charger *charger, int props)
> enum power_supply_property *prop;
> struct z2_battery_info *info = charger->info;
>
> + if (info->charge_gpio>= 0)
> + props++; /* POWER_SUPPLY_PROP_STATUS */
Why not align this comment with the below one?
> if (info->batt_tech>= 0)
> props++; /* POWER_SUPPLY_PROP_TECHNOLOGY */
> if (info->batt_I2C_reg>= 0)
WBR, Sergei
next prev parent reply other threads:[~2011-03-11 12:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-11 10:03 [PATCH] z2-battery: Fix count of properties Vasily Khoruzhick
2011-03-11 12:11 ` Sergei Shtylyov [this message]
2011-03-11 13:09 ` [PATCH v2] " Vasily Khoruzhick
2011-03-11 21:36 ` Marek Vasut
2011-03-16 13:55 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D7A1181.2000802@ru.mvista.com \
--to=sshtylyov@mvista.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.