From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Haxby Subject: Re: [PATCH] fbfront: advertise either absolute or relative coordinates Date: Fri, 11 Mar 2011 12:43:08 +0000 Message-ID: <4D7A18DC.50500@oracle.com> References: <20110310175822.GA32033@aepfle.de> <20110310181404.GA3333@aepfle.de> <4D792D59.9040801@tycho.nsa.gov> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4D792D59.9040801@tycho.nsa.gov> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Eamon Walsh Cc: Olaf Hering , "xen-devel@lists.xensource.com" , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On 10/03/11 19:58, Eamon Walsh wrote: > We have had an issue here where the "request-abs-pointer" key is appearing in XenStore _after_ the backend has gone to the Connected state. Qemu xenfb.c checks for this key in the "connect()" callback, causing it to miss the key and default to relative coordinates. This was submitted to qemu-devel ages ago -- 27-Aug-2010 according to my archives. That was in fact the second time it was submitted (by Stefano) but it was never picked up despite a couple of reminders :-( This is the original thread on xen-devel: http://markmail.org/thread/fikfzaxgaj4ay6oe And the resend-thread in qemu-devel: http://lists.gnu.org/archive/html/qemu-devel/2010-08/msg01515.html I think the patch you proposed, Eamon, is the same as the one that didn't work properly -- it's certainly a lot simpler than the two-part patch that I wrote (and that patch has been in production for OracleVM for a while, it seems solid). jch