[Qemu-devel] Re: [PATCH v2] Make VNC support optional

[Jes Sorensen <Jes.Sorensen@redhat.com>]

On 03/11/11 15:55, Anthony Liguori wrote:
> On 03/11/2011 08:54 AM, Jes Sorensen wrote:
>> On 03/11/11 15:39, Anthony Liguori wrote:
>>>> +#ifdef CONFIG_VNC
>>>>        /* init remote displays */
>>>>        if (vnc_display) {
>>>>            vnc_display_init(ds);
>>>> @@ -3088,6 +3095,7 @@ int main(int argc, char **argv, char **envp)
>>>>                printf("VNC server running on `%s'\n",
>>>> vnc_display_local_addr(ds));
>>>>            }
>>>>        }
>>>> +#endif
>>> So what ends up being the default display if VNC and SDL are both
>>> disabled?  Have you tested this?
>> Then you cry :) actually you just don't get video output, a bit like if
>> you run with -nographic, except it doesn't try to force taking over
>> stdio. This is intentional btw :)
> 
> Hrm, that doesn't sound very safe to me.  Forcing -nographic would be
> better IMHO.

-nographic is bad, it forces a takeover of stdio preventing you from
running the monitor on stdio in this case. Not necessarily what you
want. We could do an alternative mode for this, but -nographic is not
what we want in this case.

Cheers,
Jes