Re: [Printing-architecture] [Printing-japan] Ubuntu Natty the first distribution which does automatic download of binary printer driver packages

[Till Kamppeter <till.kamppeter@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 789 bytes --]

On 03/11/2011 04:03 AM, Olaf Meeuwissen wrote:
>   4. Jockey not called by system-config-printer?
>      We seen some discrepancies in behaviour wrt the automatic printer
>      driver download depending on how the printer was "detected".
>      Connecting a USB printer worked fine.  Running newprinter.py from
>      the command-line is also okay.  However, when trying to add a USB
>      or network printer using system-config-printer nothing happened.
>      As in no attempt to have jockey download a driver was made.
>      I'll submit a bug report against system-config-printer later as I
>      don't have the details handy at the moment.

Tim, the patch to fix this (and which I have applied to the Ubuntu 
package) is attached./ Please apply it also upstream. Thanks.

    Till

[-- Attachment #2: 0001-Assured-that-on-all-uses-of-the-ppdsloader-class-the.patch --]
[-- Type: text/x-patch, Size: 2116 bytes --]

From 2bd9546c93d33e58bb03ff252091c8ea680c21ec Mon Sep 17 00:00:00 2001
From: Till Kamppeter <till.kamppeter@gmail.com>
Date: Fri, 11 Mar 2011 17:10:56 +0100
Subject: [PATCH] Assured that on all uses of the ppdsloader class the device ID is supplied

In some cases during the creation or the modification of a print queue
(newprinter.py) a device ID was available but it did not get supplied
to the ppdsloader class and this caused automatic driver downloads not
to get triggered.
---
 newprinter.py |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/newprinter.py b/newprinter.py
index 0d58a40..fa113cc 100644
--- a/newprinter.py
+++ b/newprinter.py
@@ -637,6 +637,8 @@ class NewPrinterGUI(GtkGUI):
 
             if self.dialog_mode == "ppd":
                 devid = self.device.id
+                if not self.devid:
+                    self.devid = devid
 
             if not devid:
                 devid = None
@@ -655,6 +657,8 @@ class NewPrinterGUI(GtkGUI):
                                         include_schemes=schemes,
                                         reply_handler=self.change_ppd_got_devs,
                                         error_handler=self.change_ppd_got_devs)
+                if self.devid:
+                    devid = self.devid
 
             self.ntbkNewPrinter.set_current_page(2)
             self.rbtnNPFoomatic.set_active (True)
@@ -714,6 +718,7 @@ class NewPrinterGUI(GtkGUI):
                 devid = device.id
                 mm = device.make_and_model
                 self.device = device
+                self.devid = devid
 
         # We'll also need the list of PPDs.
         self.ppdsloader = ppdsloader.PPDsLoader (device_id=devid,
@@ -970,6 +975,8 @@ class NewPrinterGUI(GtkGUI):
 
                 if not self.remotecupsqueue:
                     if self.ppds == None:
+                        if self.device.id and not self.devid:
+                            self.devid = self.device.id
                         devid = self.devid
                         if not devid:
                             devid = None
-- 
1.7.4.1