Re: [PATCH 1/5 v2] Add new UUID utility functions

[Brian Gix <bgix@codeaurora.org>]

On 3/11/2011 10:02 AM, Claudio Takahasi wrote:
> Hi Johan/Brian,
>
> On Fri, Mar 11, 2011 at 2:30 PM, Elvis Pfützenreuter<epx@signove.com>  wrote:
>> From: Claudio Takahasi<claudio.takahasi@openbossa.org>
>>
>> New UUID functions will store the UUIDs values on host order. Added
>> functions to create, compare and convert UUIDs.

[...]

>> +
>> +       memcpy(&uuid128->value.u128.data[BASE_UUID16_OFFSET],
>> +&uuid16->value.u16, sizeof(uuid16->value.u16));
>
> Are you fine with memcpy or it is better to use assignments(as
> proposed by Brian)?

Well, the memcpy does have the added advantage of being more immune to 
memory alignment issues.  These structures are all multiple of 4 bytes, 
so it probably doesn't matter, but the memcpy will place the data in the 
correct place for all supported architectures, without any danger of 
misalignment exceptions.  I'd now keep it as a memcpy.


Regards,

-- 
Brian Gix
bgix@codeaurora.org
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum