Re: [PATCH] Isimodem: Crash while setting SCA

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 836 bytes --]

Hi Arun,

On 03/11/2011 06:49 AM, ext-arun.1.ravindran(a)nokia.com wrote:
> From: Arun Ravindran <ext-arun.1.ravindran@nokia.com>
> 
> ---
>  drivers/isimodem/sms.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 

I applied the patch, however...

> diff --git a/drivers/isimodem/sms.c b/drivers/isimodem/sms.c
> index 957b342..c90c06d 100644
> --- a/drivers/isimodem/sms.c
> +++ b/drivers/isimodem/sms.c
> @@ -292,7 +292,7 @@ static void isi_sca_set(struct ofono_sms *sms,
>  		{ &sd->params, sizeof(sd->params) },
>  	};
>  
> -	if (cbd == NULL || sd == NULL)
> +	if (cbd == NULL || sd == NULL || sd->sim == NULL)

The check for sd == NULL is too late since sd->params is being used up
above for initialization of iov...

>  		goto error;
>  
>  	bcd = sd->params.sca;

Regards,
-Denis