Re: [LTP] [PATCH] ftest06.c: fix error of the child process need exit

[Caspar Zhang <czhang@redhat.com>]

On 03/12/2011 05:50 PM, Peng Haitao wrote:
> 
> The child process should exit after invoking dotest().
> 
> Signed-off-by: Peng Haitao <penght@cn.fujitsu.com>

Confirmed this patch and the other ftest06 patch both work on RHEL6.

Tested-by: Caspar Zhang <czhang@redhat.com>

> ---
>  testcases/kernel/fs/ftest/ftest06.c |    7 ++-----
>  1 files changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/testcases/kernel/fs/ftest/ftest06.c b/testcases/kernel/fs/ftest/ftest06.c
> index d8ff8b6..18eae5d 100644
> --- a/testcases/kernel/fs/ftest/ftest06.c
> +++ b/testcases/kernel/fs/ftest/ftest06.c
> @@ -110,9 +110,8 @@ int main(int ac, char *av[])
>  	/*
>  	 * parse standard options
>  	 */
> -	if ((msg = parse_opts(ac, av, NULL, NULL)) != NULL) {
> +	if ((msg = parse_opts(ac, av, NULL, NULL)) != NULL)
>  		tst_brkm(TBROK, NULL, "OPTION PARSING ERROR - %s", msg);
> -	}
>  
>  	/*
>  	 * Default values for run conditions.
> @@ -162,7 +161,7 @@ int main(int ac, char *av[])
>  		for (k = 0; k < nchild; k++) {
>  			if ((child = fork()) == 0) {
>  				dotest(k, iterations);
> -
> +				tst_exit();
>  			}
>  			if (child < 0) {
>  				tst_brkm(TBROK|TERRNO, cleanup, "fork failed");
> @@ -239,8 +238,6 @@ int main(int ac, char *av[])
>  		}
>  
>  		sync();
> -		cleanup();
> -
>  	}
>  
>  	if (local_flag == FAILED)


-- 
Quality Engineer (Kernel) in
Red Hat Software (Beijing) Co., R&D Branch
http://www.cn.redhat.com/
TEL: +86-10-62608150

------------------------------------------------------------------------------
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list