From: Lai Jiangshan <laijs@cn.fujitsu.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3]trace-cmd: remove dead code
Date: Mon, 14 Mar 2011 10:30:37 +0800 [thread overview]
Message-ID: <4D7D7DCD.7010200@cn.fujitsu.com> (raw)
In-Reply-To: <1299768818.15854.343.camel@gandalf.stny.rr.com>
On 03/10/2011 10:53 PM, Steven Rostedt wrote:
> On Thu, 2011-03-10 at 17:57 +0800, Lai Jiangshan wrote:
>> filter_cpu related code is totally dead.
>
> I'll rephrase this, as it is not dead. "dead" code is code that can not
> be reached. This code most certainly can be reached. You may think it is
> silly code, which it may be. The reason for the separation of one CPU
> and multiple CPUs, is I do one CPU more often than I filter multiple,
> and I wanted the 1 cpu to still be efficient.
>
I'm confused, filter_cpu is always -1, how the code can be reached?
next prev parent reply other threads:[~2011-03-14 2:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-10 9:57 [PATCH 1/3]trace-cmd: remove dead code Lai Jiangshan
2011-03-10 14:53 ` Steven Rostedt
2011-03-14 2:30 ` Lai Jiangshan [this message]
2011-03-14 13:28 ` Steven Rostedt
2011-03-14 2:39 ` [PATCH 1/3 V2]trace-cmd: " Lai Jiangshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D7D7DCD.7010200@cn.fujitsu.com \
--to=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.