From: Mike Christie <michaelc@cs.wisc.edu>
To: Vikas Chaudhary <vikas.chaudhary@qlogic.com>
Cc: James Bottomley <James.Bottomley@suse.de>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
Lalit Chandivade <lalit.chandivade@qlogic.com>,
Ravi Anand <ravi.anand@qlogic.com>,
Karen Higgins <karen.higgins@qlogic.com>
Subject: Re: [PATCH 04/13] qla4xxx: cleanup DDB relogin logic during initialization
Date: Mon, 14 Mar 2011 16:55:46 -0500 [thread overview]
Message-ID: <4D7E8EE2.7070107@cs.wisc.edu> (raw)
In-Reply-To: <5E4F49720D0BAD499EE1F01232234BA872263B150A@AVEXMB1.qlogic.org>
On 03/14/2011 12:24 AM, Vikas Chaudhary wrote:
> diff --git a/drivers/scsi/qla4xxx/ql4_init.c b/drivers/scsi/qla4xxx/ql4_init.c
> index 22fc57e..bf1c30b 100644
> --- a/drivers/scsi/qla4xxx/ql4_init.c
> +++ b/drivers/scsi/qla4xxx/ql4_init.c
> @@ -723,13 +723,38 @@ int qla4_is_relogin_allowed(struct scsi_qla_host *ha, uint32_t conn_err)
> return relogin;
> }
>
> +static void qla4xxx_flush_AENS(struct scsi_qla_host *ha)
> +{
I think it is ok for now since the patch is moving the old function, but
in some future coding style cleanup patch could you fix mixed cases like
this. So it would be qla4xxx_flush_aens instead of _AENS. It then
matches the kernel coding style and matches functions like
qla4xxx_process_aen.
> -
> -static void qla4xxx_flush_AENS(struct scsi_qla_host *ha)
next prev parent reply other threads:[~2011-03-14 21:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-14 5:24 [PATCH 04/13] qla4xxx: cleanup DDB relogin logic during initialization Vikas Chaudhary
2011-03-14 21:55 ` Mike Christie [this message]
2011-03-15 9:42 ` Vikas Chaudhary
-- strict thread matches above, loose matches on Subject: below --
2011-03-21 10:34 [PATCH 01/13] qla4xxx: cleanup qla4xxx_initialize_ddb_list() vikas.chaudhary
2011-03-21 10:34 ` [PATCH 04/13] qla4xxx: cleanup DDB relogin logic during initialization vikas.chaudhary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D7E8EE2.7070107@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=James.Bottomley@suse.de \
--cc=karen.higgins@qlogic.com \
--cc=lalit.chandivade@qlogic.com \
--cc=linux-scsi@vger.kernel.org \
--cc=ravi.anand@qlogic.com \
--cc=vikas.chaudhary@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.