All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Hancock <hancockrwd@gmail.com>
To: mbizon@freebox.fr
Cc: Jeff Garzik <jgarzik@pobox.com>, Tejun Heo <htejun@gmail.com>,
	linux-ide <linux-ide@vger.kernel.org>
Subject: Re: "irq 4: nobody cared" when loading ahci driver on ce4100
Date: Mon, 14 Mar 2011 18:59:23 -0600	[thread overview]
Message-ID: <4D7EB9EB.8030807@gmail.com> (raw)
In-Reply-To: <1300129707.28545.34.camel@sakura.staff.proxad.net>

On 03/14/2011 01:08 PM, Maxime Bizon wrote:
>
> Hi Jeff&  all,
>
> I'm using an Intel CE4100 platform (Sodaville), and when I load the ahci
> driver I get a short lock, then this message.
>
> On the original ahci driver (back in 2007), the ata port interrupts were
> not enabled until irq handler was registred (in ahci_thaw()).
>
> But since commit 1c954a4d9a9e351fa3509533fd8dd5f3821206cd (ahci: clean
> up PORT_IRQ_BAD_PMP enabling), it is now done early in
> ahci_pmp_attach/ahci_pmp_detach:
>
> ata_host_activate =>  port_start() callback =>  ahci_port_resume()
>
> before ahci interrupt handler is even registered.
>
> On my board, port irq stat is 0x00400040 before port mask is changed,
> that's why interrupt is triggered immediately.
>
> Any idea on the clean way to fix this ?

Where is ahci_thaw being called? It shouldn't be called before the IRQ 
handler is registered - I think it should only be called from the error 
handler which would be way later..

  reply	other threads:[~2011-03-15  0:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-14 19:08 "irq 4: nobody cared" when loading ahci driver on ce4100 Maxime Bizon
2011-03-15  0:59 ` Robert Hancock [this message]
2011-03-15  4:20   ` Maxime Bizon
2011-03-15  7:19     ` Tejun Heo
2011-03-15 14:48       ` Maxime Bizon
2011-03-15 15:03         ` Maxime Bizon
2011-03-15 15:19           ` Tejun Heo
2011-03-15 17:03             ` Maxime Bizon
2011-03-15 21:22             ` [PATCH] ahci: don't enable port irq before handler is registered Maxime Bizon
2011-03-16  9:04               ` Tejun Heo
2011-03-16  9:05                 ` Tejun Heo
2011-03-16 13:58                 ` [PATCH v2] " Maxime Bizon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D7EB9EB.8030807@gmail.com \
    --to=hancockrwd@gmail.com \
    --cc=htejun@gmail.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=mbizon@freebox.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.