From: Reinhard Meyer <u-boot@emk-elektronik.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH AT91] Add watchdog reset to the at91samx SOC family
Date: Tue, 15 Mar 2011 13:01:15 +0100 [thread overview]
Message-ID: <4D7F550B.4050302@emk-elektronik.de> (raw)
In-Reply-To: <20110315112717.GA24904@gandalf.sssup.it>
Dear Michael Trimarchi,
> This patch add the watchdog reset function to the atmel atsam9x architectures.
NAK.
Watchdog already exists at drivers/watchdog/at91sam9_wdt.c :)
Maybe its a bit of an obscure location... But it is already invented ;)
> + int re_enable = disable_interrupts();
> +
> + writel(AT91_WDT_CR_WDRSTT | AT91_WDT_CR_KEY, &wdt->cr);
> +
> + if (re_enable)
> + enable_interrupts();
Besides... why would we need to disable IRQs here, writel() is using one instruction
to write to the address?
Best Regards,
Reinhard
next prev parent reply other threads:[~2011-03-15 12:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-15 11:27 [U-Boot] [PATCH AT91] Add watchdog reset to the at91samx SOC family Michael Trimarchi
2011-03-15 12:01 ` Reinhard Meyer [this message]
2011-03-15 12:09 ` Michael Trimarchi
2011-03-15 12:50 ` Michael Trimarchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D7F550B.4050302@emk-elektronik.de \
--to=u-boot@emk-elektronik.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.