From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Trimarchi <trimarchi@gandalf.sssup.it>
Date: Tue, 15 Mar 2011 13:09:47 +0100
Subject: [U-Boot] [PATCH AT91] Add watchdog reset to the at91samx SOC
	family
In-Reply-To: <4D7F550B.4050302@emk-elektronik.de>
References: <20110315112717.GA24904@gandalf.sssup.it>
	<4D7F550B.4050302@emk-elektronik.de>
Message-ID: <4D7F570B.9030003@gandalf.sssup.it>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

HI

On 03/15/2011 01:01 PM, Reinhard Meyer wrote:
> Dear Michael Trimarchi,
>> This patch add the watchdog reset function to the atmel atsam9x architectures.
> 
> NAK.
> 
> Watchdog already exists at drivers/watchdog/at91sam9_wdt.c :)
> 
> Maybe its a bit of an obscure location... But it is already invented ;)
> 
>> +	int re_enable = disable_interrupts();
>> +
>> +	writel(AT91_WDT_CR_WDRSTT | AT91_WDT_CR_KEY, &wdt->cr);
>> +
>> +	if (re_enable)
>> +		enable_interrupts();
> 

Yes was obscured, and it is the only one :) there

Michael

> Besides... why would we need to disable IRQs here, writel() is using one instruction
> to write to the address?
> 
> Best Regards,
> 
> Reinhard
>