From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 1/2] netfilter: ipt_addrtype: rename to xt_addrtype
Date: Tue, 15 Mar 2011 14:29:32 +0100 [thread overview]
Message-ID: <4D7F69BC.2090309@trash.net> (raw)
In-Reply-To: <alpine.LNX.2.01.1103092120570.22286@obet.zrqbmnf.qr>
On 09.03.2011 21:21, Jan Engelhardt wrote:
> On Wednesday 2011-03-09 20:54, Florian Westphal wrote:
>
>> Jan Engelhardt <jengelh@medozas.de> wrote:
>>> On Tuesday 2011-03-08 16:11, Patrick McHardy wrote:
>>>
>>>> Am 05.03.2011 17:08, schrieb Florian Westphal:
>>>>> From: Florian Westphal <fwestphal@astaro.com>
>>>>>
>>>>> followup patch will add ipv6 support.
>>>>>
>>>>> Signed-off-by: Florian Westphal <fwestphal@astaro.com>
>>>>> ---
>>>>> include/linux/netfilter/Kbuild | 1 +
>>>>> .../ipt_addrtype.h => netfilter/xt_addrtype.h} | 16 +++++-----
>>>>
>>>> Please keep this file and the original definitions for a while
>>>> (add to feature-removal-schedule) for compatibility. You can
>>>> redefine them to the xt_ values/structures so they can be used
>>>> inside the kernel.
>>>
>>> Just like ipt_realm.h does, yeah.
>>
>> Sorry, redefining structures and enums is really not my cup of tea.
>>
>> If thats really what you would prefer (as opposed to keeping the file
>> as-is) I can send a V3 patch that includes xt_addrtype.h and then
>> re-defines the enums/structures with the ipt_ prefixes.
>>
>> But personally I would prefer to just keep it as-is and then remove it
>> in a year or so.
>
> I don't mind, t'was just a suggestion because ipt_realm happened to hit
> my eye.
I don't mind either as long as we keep the old definitions.
prev parent reply other threads:[~2011-03-15 13:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-05 16:08 [PATCH 1/2] netfilter: ipt_addrtype: rename to xt_addrtype Florian Westphal
2011-03-05 16:08 ` [PATCH 2/2] netfilter: xt_addrtype: ipv6 support Florian Westphal
2011-03-08 15:11 ` [PATCH 1/2] netfilter: ipt_addrtype: rename to xt_addrtype Patrick McHardy
2011-03-09 19:06 ` Jan Engelhardt
2011-03-09 19:54 ` Florian Westphal
2011-03-09 20:21 ` Jan Engelhardt
2011-03-15 13:29 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D7F69BC.2090309@trash.net \
--to=kaber@trash.net \
--cc=fw@strlen.de \
--cc=jengelh@medozas.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.