From: lars@metafoo.de (Lars-Peter Clausen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/1] Add core support for QQ2440.
Date: Tue, 15 Mar 2011 19:36:45 +0100 [thread overview]
Message-ID: <4D7FB1BD.6000304@metafoo.de> (raw)
In-Reply-To: <20110314132312.GB11441@dandreoli.com>
On 03/14/2011 02:23 PM, Domenico Andreoli wrote:
>+static void qq2440_udc_pullup(enum s3c2410_udc_cmd_e cmd)
>+{
>+ pr_debug("udc: pullup(%d)\n", cmd);
>+
>+ switch (cmd) {
>+ case S3C2410_UDC_P_ENABLE:
>+ gpio_set_value(S3C2410_GPG(12), 1);
>+ break;
>+ case S3C2410_UDC_P_DISABLE:
>+ gpio_set_value(S3C2410_GPG(12), 0);
>+ break;
>+ case S3C2410_UDC_P_RESET:
>+ break;
>+ default:
>+ break;
>+ }
>+}
>+
>+static struct s3c2410_udc_mach_info qq2440_udc_cfg __initdata = {
>+ .udc_command = qq2440_udc_pullup,
>+};
I've recently added support to the s3c2410_udc driver to handle controlling the
pullup itself if an gpio is used[1].
You should be able to simplify this part to:
+static struct s3c2410_udc_mach_info qq2440_udc_cfg __initdata = {
+ .pullup_pin = S3C2410_GPG(12),
+};
- Lars
[1]
http://git.kernel.org/?p=linux/kernel/git/gregkh/usb-2.6.git;a=commit;h=a74022a55e44fe2044ac3660452cafecb300aece
prev parent reply other threads:[~2011-03-15 18:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110314131837.540942890@gmail.com>
2011-03-14 13:23 ` [PATCH v2 1/1] Add core support for QQ2440 Domenico Andreoli
2011-03-15 17:59 ` Jamie Iles
2011-03-15 18:36 ` Lars-Peter Clausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D7FB1BD.6000304@metafoo.de \
--to=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.