From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=47520 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q0FSa-0003oY-0c
	for qemu-devel@nongnu.org; Thu, 17 Mar 2011 11:50:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1Q0FSU-0003me-OI
	for qemu-devel@nongnu.org; Thu, 17 Mar 2011 11:49:55 -0400
Received: from isrv.corpit.ru ([86.62.121.231]:54813)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1Q0FSU-0003ls-B9
	for qemu-devel@nongnu.org; Thu, 17 Mar 2011 11:49:54 -0400
Message-ID: <4D822D9D.50907@msgid.tls.msk.ru>
Date: Thu, 17 Mar 2011 18:49:49 +0300
From: Michael Tokarev <mjt@tls.msk.ru>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH +STABLE-0.14] exit if -drive specified is
	invalid instead of ignoring the "wrong" -drive
References: <4D81BF12.4020500@msgid.tls.msk.ru> <4D822301.6050206@redhat.com>
In-Reply-To: <4D822301.6050206@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org

17.03.2011 18:04, Kevin Wolf wrote:
> Am 17.03.2011 08:58, schrieb Michael Tokarev:
[]
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -2098,7 +2098,8 @@ int main(int argc, char **argv, char **envp)
>>                            HD_OPTS);
>>                  break;
>>              case QEMU_OPTION_drive:
>> -                drive_def(optarg);
>> +                if (drive_def(optarg) == NULL)
>> +                    exit(1);
> 
> Coding style requires braces here.

I'll just stick it into debian package.  I'm not going
to change all the other braces like this around that place.

Thanks.

/mjt