All of lore.kernel.org
 help / color / mirror / Atom feed
From: gerg@snapgear.com (Greg Ungerer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/9] lpc2k: Exception vector handling
Date: Fri, 18 Mar 2011 10:43:22 +1000	[thread overview]
Message-ID: <4D82AAAA.1070804@snapgear.com> (raw)
In-Reply-To: <1300379337.2138.88.camel@team-embedded-2>

On 18/03/11 02:28, Ithamar R. Adema wrote:
> On Thu, 2011-03-17 at 17:18 +0100, Uwe Kleine-K??nig wrote:
>> On Thu, Mar 17, 2011 at 04:54:17PM +0100, Ithamar R. Adema wrote:
>>> diff --git a/arch/arm/kernel/entry-armv.S b/arch/arm/kernel/entry-armv.S
>>> index e8d8856..618a971 100644
>>> --- a/arch/arm/kernel/entry-armv.S
>>> +++ b/arch/arm/kernel/entry-armv.S
>>> @@ -1208,6 +1208,7 @@ __stubs_end:
>>>
>>>   	.globl	__vectors_start
>>>   __vectors_start:
>>> +#ifndef CONFIG_ARCH_LPC2K
>>>    ARM(	swi	SYS_ERROR0	)
>>>    THUMB(	svc	#0		)
>>>    THUMB(	nop			)
>>> @@ -1218,6 +1219,23 @@ __vectors_start:
>>>   	W(b)	vector_addrexcptn + stubs_offset
>>>   	W(b)	vector_irq + stubs_offset
>>>   	W(b)	vector_fiq + stubs_offset
>>> +#else /* CONFIG_ARCH_LPC2K */
>> The description from the commit log should be repeated here.
>
> OK, will include the description as comment there in the next version.
>
>> And I wonder if this shouldn't depend on CONFIG_ARCH_LPC2K but
>> CONFIG_MMU.
>
> Well, looking at th uClinux kernel tree, it seems this was only done for
> the NXP LPC2K range, so that's why I kept it under CONFIG_ARCH_LPC2K.

IIRC most of the non-MMU ARMs had the vectors in normal RAM, so they
would end up close to the code. That is why this may have been the
only one with the vectors ending up a long way away. So it is not
specific to non-MMU, but one day there may be other types that need
to do this too.

Regards
Greg


>>> +	swi	SYS_ERROR0
>> I think arm7tdmi doesn't have thumb2, does it? If it has you need to do
>> ARM(swi SYS_ERROR0)
>> THUMB(svc ..)
>> ...
>>
>> as above
>
> Correct, the ARM7TDMI-S only supports Thumb, not Thumb2.
>
> Thanks for reviewing!
>
> Ithamar.
>
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
>
>


-- 
------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg at snapgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
8 Gardner Close                             FAX:         +61 7 3217 5323
Milton, QLD, 4064, Australia                WEB: http://www.SnapGear.com

  reply	other threads:[~2011-03-18  0:43 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-17 15:54 [PATCH 0/9] Support for NXP LPC2K SoCs Ithamar R. Adema
2011-03-17 15:54 ` [PATCH 1/9] lpc2k: Core support Ithamar R. Adema
2011-03-17 21:26   ` Jamie Iles
2011-03-17 21:32   ` Vitaly Wool
2011-03-17 21:50     ` Ithamar R. Adema
2011-03-17 22:08   ` Kevin Wells
2011-03-17 22:25     ` Ithamar R. Adema
2011-03-17 15:54 ` [PATCH 2/9] lpc2k: Exception vector handling Ithamar R. Adema
2011-03-17 16:18   ` Uwe Kleine-König
2011-03-17 16:28     ` Ithamar R. Adema
2011-03-18  0:43       ` Greg Ungerer [this message]
2011-03-17 15:54 ` [PATCH 3/9] lpc2k: clk API Ithamar R. Adema
2011-03-17 22:08   ` Kevin Wells
2011-03-18  9:44     ` Ithamar R. Adema
2011-03-17 22:16   ` Kevin Wells
2011-03-17 22:29     ` Ithamar R. Adema
2011-03-17 15:54 ` [PATCH 4/9] lpc2k: generic time and clockevents Ithamar R. Adema
2011-03-17 21:38   ` Jamie Iles
2011-03-17 22:00     ` Ithamar R. Adema
2011-03-17 15:54 ` [PATCH 5/9] lpc2k: gpiolib Ithamar R. Adema
2011-03-17 15:54 ` [PATCH 6/9] lpc2k: multifunction pin configuration Ithamar R. Adema
2011-03-17 15:54 ` [PATCH 7/9] lpc2k: Add EmbeddedArtists LPC2478 Developer's Kit board Ithamar R. Adema
2011-03-17 22:07   ` Kevin Wells
2011-03-17 22:18     ` Ithamar R. Adema
2011-03-17 22:33   ` Kevin Wells
2011-03-17 22:49     ` Ithamar R. Adema
2011-03-17 15:54 ` [PATCH 8/9] lpc2k: Add UART, SSP, and MCI devices Ithamar R. Adema
2011-03-17 15:54 ` [PATCH 9/9] lpc2k: defconfig for NXP LPC2K platform Ithamar R. Adema
2011-03-17 17:18 ` [PATCH 0/9] Support for NXP LPC2K SoCs Kevin Wells
2011-03-18  0:45 ` Greg Ungerer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D82AAAA.1070804@snapgear.com \
    --to=gerg@snapgear.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.